Remove deprecated IBMQ dependent functionality #11513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes all the functionality in Qiskit that depended on the legacy qiskit-ibmq-provider package. This process was started in Qiskit#10525 which removed the qiskit.IBMQ alias object but as was discovered in that PR there were many other places in qiskit that were relying on the qiskit-ibmq-provider package. This commit removes all of these places, which primarily include qiskit.test.decorators's online_test decorator, qiskit.tools.jupyter, qiskit.tools.monitor, qiskit.test.ibmq_mock, and qiskit.test.mock (which just referenced IBMQ and didn't actually use it). With these removals we're also no longer optionally dependent on ipywidgets, jupyter, or ipython and those are removed from the optional and development requirements lists.
mtreinish
added
the
Changelog: Removal
|
One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 7481893451Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
mtreinish
added a commit
to mtreinish/qiskit-core
that referenced
this pull request
Jan 8, 2024
This commit removes all the functionality in `qiskit.tools` with the exception of `parallel_map` which has been migrated to `qiskit.utils`. This PR does not cover the removal of `qiskit.tools.jupyter` or `qiskit.tools.monitor` which are covered by Qiskit#11513.
mtreinish
added a commit
to mtreinish/qiskit-core
that referenced
this pull request
Jan 8, 2024
This commit removes all the functionality in `qiskit.tools` with the exception of `parallel_map` which has been migrated to `qiskit.utils`. This PR does not cover the removal of `qiskit.tools.jupyter` or `qiskit.tools.monitor` which are covered by Qiskit#11513.
mtreinish
changed the title
jakelishman
reviewed
Jan 9, 2024
There was a problem hiding this comment.
This has a large amount of overlap with #11445, but that's no problem. Mostly this looks fine to me, just very minor comments.
Merged
jakelishman
approved these changes
Jan 10, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 11, 2024
* Remove qiskit.tools module This commit removes all the functionality in `qiskit.tools` with the exception of `parallel_map` which has been migrated to `qiskit.utils`. This PR does not cover the removal of `qiskit.tools.jupyter` or `qiskit.tools.monitor` which are covered by #11513. * Update qiskit/utils/__init__.py Co-authored-by: Jake Lishman <[email protected]> --------- Co-authored-by: Jake Lishman <[email protected]>
ShellyGarion
pushed a commit
to ShellyGarion/qiskit-terra
that referenced
this pull request
Jan 18, 2024
* Remove deprecate IBMQ dependent functionality This commit removes all the functionality in Qiskit that depended on the legacy qiskit-ibmq-provider package. This process was started in Qiskit#10525 which removed the qiskit.IBMQ alias object but as was discovered in that PR there were many other places in qiskit that were relying on the qiskit-ibmq-provider package. This commit removes all of these places, which primarily include qiskit.test.decorators's online_test decorator, qiskit.tools.jupyter, qiskit.tools.monitor, qiskit.test.ibmq_mock, and qiskit.test.mock (which just referenced IBMQ and didn't actually use it). With these removals we're also no longer optionally dependent on ipywidgets, jupyter, or ipython and those are removed from the optional and development requirements lists. * Remove stale api docs * Remove ibmq usage in fake backend update script * Preserve circuit library visualizations * Remove apidocs from index * Remove unused import * Update docs
ShellyGarion
pushed a commit
to ShellyGarion/qiskit-terra
that referenced
this pull request
Jan 18, 2024
* Remove qiskit.tools module This commit removes all the functionality in `qiskit.tools` with the exception of `parallel_map` which has been migrated to `qiskit.utils`. This PR does not cover the removal of `qiskit.tools.jupyter` or `qiskit.tools.monitor` which are covered by Qiskit#11513. * Update qiskit/utils/__init__.py Co-authored-by: Jake Lishman <[email protected]> --------- Co-authored-by: Jake Lishman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit removes all the functionality in Qiskit that depended on the legacy qiskit-ibmq-provider package. This process was started in #10525 which removed the qiskit.IBMQ alias object but as was discovered in that PR there were many other places in qiskit that were relying on the qiskit-ibmq-provider package. This commit removes all of these places, which primarily include qiskit.test.decorators's online_test decorator, qiskit.tools.jupyter, qiskit.tools.monitor, qiskit.test.ibmq_mock, and qiskit.test.mock (which just referenced IBMQ and didn't actually use it). With these removals we're also no longer optionally dependent on ipywidgets, jupyter, or ipython and those are removed from the optional and development requirements lists.
Details and comments