Fix clippy issue on Rust 1.75 #11492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the recent release of Rust 1.75 there were some new clippy rules enabled. There was one minor usage issue highlighted in the new release. While we pin the rust version in CI when building and running clippy locally with the latest version this would trigger a failure. This commit fixes the one issue highlighted by clippy on Rust 1.75 which replaces `Vec<T>.get(0)` with `Vec<T>.first()`.
mtreinish
added
type: qa
|
One or more of the the following people are requested to review this:
|
jakelishman
previously approved these changes
Jan 4, 2024
There was a problem hiding this comment.
I'm not wild about Clippy newly turning on subjective style stuff like this at deny-by-default, but it is what it is. Still good to make Clippy happy.
If we were MSRV 1.65+, we could have done this as a one-liner:
let Some(first_elem) = memory.first() else { return Ok(Vec::<String>::new().to_object(py)) };but no let-else for us in 1.64 land.
Pull Request Test Coverage Report for Build 7414974491
💛 - Coveralls |
See #11493 we can wait on that to merge first and then update this to use that |
jakelishman
approved these changes
Jan 4, 2024
|
Oh no need to change it - it's just another stylistic thing. It was only on my mind because I think let-else was one of the things we talked about when deciding between 1.64 and 1.65. |
ShellyGarion
pushed a commit
to ShellyGarion/qiskit-terra
that referenced
this pull request
Jan 18, 2024
With the recent release of Rust 1.75 there were some new clippy rules enabled. There was one minor usage issue highlighted in the new release. While we pin the rust version in CI when building and running clippy locally with the latest version this would trigger a failure. This commit fixes the one issue highlighted by clippy on Rust 1.75 which replaces `Vec<T>.get(0)` with `Vec<T>.first()`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With the recent release of Rust 1.75 there were some new clippy rules enabled. There was one minor usage issue highlighted in the new release. While we pin the rust version in CI when building and running clippy locally with the latest version this would trigger a failure. This commit fixes the one issue highlighted by clippy on Rust 1.75 which replaces
Vec<T>.get(0)withVec<T>.first().Details and comments