-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix global-phase of copied BlueprintCircuit
s
#11456
Merged
kevinhartman
merged 1 commit into
Qiskit:main
from
jakelishman:fix-blueprintcircuit-copy
Jan 3, 2024
Merged
Fix global-phase of copied BlueprintCircuit
s
#11456
kevinhartman
merged 1 commit into
Qiskit:main
from
jakelishman:fix-blueprintcircuit-copy
Jan 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `BlueprintCircuit.copy()` or `.copy_empty_like()` would previously erase the global phase as part of the rebuild operation. This overrides `BlueprintCircuit.copy_empty_like()` to ensure that it is always propagated through.
jakelishman
added
stable backport potential
The bug might be minimal and/or import enough to be port to stable
Changelog: Bugfix
Include in the "Fixed" section of the changelog
mod: circuit
Related to the core of the `QuantumCircuit` class or the circuit library
labels
Dec 21, 2023
One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 7292776195
💛 - Coveralls |
kevinhartman
approved these changes
Jan 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mergify bot
pushed a commit
that referenced
this pull request
Jan 3, 2024
Using `BlueprintCircuit.copy()` or `.copy_empty_like()` would previously erase the global phase as part of the rebuild operation. This overrides `BlueprintCircuit.copy_empty_like()` to ensure that it is always propagated through. (cherry picked from commit 19767bc)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 3, 2024
Using `BlueprintCircuit.copy()` or `.copy_empty_like()` would previously erase the global phase as part of the rebuild operation. This overrides `BlueprintCircuit.copy_empty_like()` to ensure that it is always propagated through. (cherry picked from commit 19767bc) Co-authored-by: Jake Lishman <[email protected]>
ShellyGarion
pushed a commit
to ShellyGarion/qiskit-terra
that referenced
this pull request
Jan 18, 2024
Using `BlueprintCircuit.copy()` or `.copy_empty_like()` would previously erase the global phase as part of the rebuild operation. This overrides `BlueprintCircuit.copy_empty_like()` to ensure that it is always propagated through.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Changelog: Bugfix
Include in the "Fixed" section of the changelog
mod: circuit
Related to the core of the `QuantumCircuit` class or the circuit library
stable backport potential
The bug might be minimal and/or import enough to be port to stable
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Using
BlueprintCircuit.copy()
or.copy_empty_like()
would previously erase the global phase as part of the rebuild operation. This overridesBlueprintCircuit.copy_empty_like()
to ensure that it is always propagated through.Details and comments