Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove QuantumCircuit.bind_parameters #11434

Merged
merged 2 commits into from
Dec 19, 2023

Conversation

jakelishman
Copy link
Member

Summary

This expires the deprecation on bind_parameters in favour of assign_parameters, which is a drop-in replacement with its defaults.

Details and comments

This expires the deprecation on `bind_parameters` in favour of
`assign_parameters`, which is a drop-in replacement with its defaults.
@jakelishman jakelishman added Changelog: Removal Include in the Removed section of the changelog mod: circuit Related to the core of the `QuantumCircuit` class or the circuit library labels Dec 19, 2023
@jakelishman jakelishman added this to the 1.0.0 milestone Dec 19, 2023
@jakelishman jakelishman requested a review from a team as a code owner December 19, 2023 15:25
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@coveralls
Copy link

coveralls commented Dec 19, 2023

Pull Request Test Coverage Report for Build 7264291991

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 37 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.05%) to 87.511%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 5 92.17%
crates/accelerate/src/quantum_circuit/circuit_data.rs 8 90.71%
crates/qasm2/src/parse.rs 24 96.2%
Totals Coverage Status
Change from base Build 7263539836: -0.05%
Covered Lines: 59141
Relevant Lines: 67581

💛 - Coveralls

Copy link
Contributor

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ElePT ElePT added this pull request to the merge queue Dec 19, 2023
Merged via the queue into Qiskit:main with commit 238f38a Dec 19, 2023
@jakelishman jakelishman deleted the remove-bind-parameters branch December 19, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Removal Include in the Removed section of the changelog mod: circuit Related to the core of the `QuantumCircuit` class or the circuit library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants