Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve stagedpassmanager docstring #11284

Merged
merged 5 commits into from
Nov 22, 2023

Conversation

kevinsung
Copy link
Contributor

Summary

Fix typos, grammar, and update wording to (hopefully) improve clarity.

Details and comments

@kevinsung kevinsung requested a review from a team as a code owner November 20, 2023 21:34
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@coveralls
Copy link

coveralls commented Nov 20, 2023

Pull Request Test Coverage Report for Build 6952792149

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 10 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.008%) to 86.453%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 4 91.92%
crates/qasm2/src/parse.rs 6 97.6%
Totals Coverage Status
Change from base Build 6951563267: -0.008%
Covered Lines: 66281
Relevant Lines: 76667

💛 - Coveralls

@mtreinish mtreinish added documentation Something is not clear or an error documentation stable backport potential The bug might be minimal and/or import enough to be port to stable Changelog: None Do not include in changelog labels Nov 20, 2023
ElePT
ElePT previously approved these changes Nov 21, 2023
Copy link
Contributor

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

qiskit/transpiler/passmanager.py Outdated Show resolved Hide resolved
qiskit/transpiler/passmanager.py Outdated Show resolved Hide resolved
Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the quick updates.

@mtreinish mtreinish added this pull request to the merge queue Nov 22, 2023
Merged via the queue into Qiskit:main with commit 33362cc Nov 22, 2023
13 checks passed
mergify bot pushed a commit that referenced this pull request Nov 22, 2023
* improve stagedpassmanager docstring

* don't call out swap gates

* reword optimization

* add word

(cherry picked from commit 33362cc)
github-merge-queue bot pushed a commit that referenced this pull request Nov 23, 2023
* improve stagedpassmanager docstring

* don't call out swap gates

* reword optimization

* add word

(cherry picked from commit 33362cc)

Co-authored-by: Kevin J. Sung <[email protected]>
@kevinsung kevinsung deleted the staged-passmanager-docs branch November 24, 2023 00:46
FabianBrings pushed a commit to FabianBrings/qiskit that referenced this pull request Nov 27, 2023
* improve stagedpassmanager docstring

* don't call out swap gates

* reword optimization

* add word
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog documentation Something is not clear or an error documentation stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants