Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate ParametricPulse (0.46) #11279

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Deprecate ParametricPulse (0.46) #11279

merged 1 commit into from
Nov 21, 2023

Conversation

TsafrirA
Copy link
Collaborator

Summary

This PR deprecates the ParametricPulse base class and pulse library.

Details and comments

The ParametricPulse library has been superseded by the SymbolicPulse library which provides QPY support and some performance improvements. It has been pending deprecation since Terra 0.22, and is now promoted to deprecation in Qiskit 0.46, ahead of removal in Qiskit 1.0. This PR adds the deprecation to the 0.46 branch.

@TsafrirA TsafrirA requested review from eggerdj, wshanks and a team as code owners November 20, 2023 08:48
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core
  • @nkanazawa1989

@TsafrirA TsafrirA mentioned this pull request Nov 20, 2023
Closed
@ElePT ElePT added Changelog: Deprecation Include in "Deprecated" section of changelog mod: pulse Related to the Pulse module labels Nov 20, 2023
@ElePT ElePT added this to the 0.46.0 milestone Nov 21, 2023
ElePT
ElePT reviewed Nov 21, 2023
View reviewed changes
Copy link
Contributor

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general. I was wondering though if there isn't any unit test that uses this feature to check that the warning is raised correctly.

@TsafrirA
Copy link
Collaborator Author

@ElePT
This unit has no tests. I thought it's not worth it to add some just for the deprecation. Especially seeing that it's going to be removed in #11281 (or #11024).

ElePT
ElePT approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, that is not ideal but I understand that just before the removal is not the best moment to add tests. The deprecation looks well done so I think that we can move forward with it.

@ElePT ElePT added this pull request to the merge queue Nov 21, 2023
Merged via the queue into Qiskit:stable/0.46 with commit 8d031ab Nov 21, 2023
14 checks passed
@TsafrirA TsafrirA deleted the ParametricPulse0-46 branch February 8, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElePT ElePT ElePT approved these changes

@eggerdj eggerdj Awaiting requested review from eggerdj eggerdj is a code owner

@wshanks wshanks Awaiting requested review from wshanks wshanks is a code owner

Assignees
No one assigned
Labels
Changelog: Deprecation Include in "Deprecated" section of changelog mod: pulse Related to the Pulse module
Projects
None yet
Milestone
0.46.0
Development

Successfully merging this pull request may close these issues.
3 participants
@TsafrirA @qiskit-bot @ElePT