Remove unnecessary installation of build requirements #11246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we are using `build`, a basic PEP 517 builder, we do not need to manually install the build requirements; our `pyproject.toml` specifies them, and they'll be automatically pulled in. With the pivot to PyPI trusted publishers in Qiskitgh-10999, we no longer use `twine` manually either.
jakelishman
added
type: qa
|
One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 6877981831
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since we are using
build, a basic PEP 517 builder, we do not need to manually install the build requirements; ourpyproject.tomlspecifies them, and they'll be automatically pulled in.With the pivot to PyPI trusted publishers in gh-10999, we no longer use
twinemanually either.Details and comments
Related to similar work in #11119 (comment).