-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removed the deprecated code since 0.23
(qiskit.visualization.pulse
)
#11213
Conversation
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 6942519686Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
releasenotes/notes/remove-deprecated-visualization-pulse-8adf40ff1a69df63.yaml
Outdated
Show resolved
Hide resolved
…0ff1a69df63.yaml Co-authored-by: Raghav <[email protected]>
0.23
0.23
(qiskit.visualization.pulse
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I just added a small formatting suggestion for the release note.
releasenotes/notes/remove-deprecated-visualization-pulse-8adf40ff1a69df63.yaml
Outdated
Show resolved
Hide resolved
…`) (Qiskit#11213) * removed the deprecated code * fixed lint and docs * Update releasenotes/notes/remove-deprecated-visualization-pulse-8adf40ff1a69df63.yaml Co-authored-by: Raghav <[email protected]> * Update releasenotes/notes/remove-deprecated-visualization-pulse-8adf40ff1a69df63.yaml * Fix reno * Fix reno --------- Co-authored-by: Raghav <[email protected]> Co-authored-by: Elena Peña Tapia <[email protected]> Co-authored-by: Elena Peña Tapia <[email protected]>
Summary
fixes issue #11144, #11145, #11146
Details and comments
Deleted
qiskit.visualization.pulse
folder, removed all the references of the class declared in the pulse folder and added a release note.@1ucian0
@ElePT