Fix build ordering of BlueprintCircuit._append
#11181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`QuantumCircuit._append` is the actual append primitive and is allowed in inner-loop appends (and for `QuantumCircuit` to assume that it's callable from other methods), so it's important that the "ensure built" check happens there, not in `append`.
jakelishman
added
stable backport potential
|
One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 6736340589
💛 - Coveralls |
mergify bot
pushed a commit
that referenced
this pull request
Nov 2, 2023
`QuantumCircuit._append` is the actual append primitive and is allowed in inner-loop appends (and for `QuantumCircuit` to assume that it's callable from other methods), so it's important that the "ensure built" check happens there, not in `append`. (cherry picked from commit a2c5412)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 2, 2023
`QuantumCircuit._append` is the actual append primitive and is allowed in inner-loop appends (and for `QuantumCircuit` to assume that it's callable from other methods), so it's important that the "ensure built" check happens there, not in `append`. (cherry picked from commit a2c5412) Co-authored-by: Jake Lishman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
QuantumCircuit._appendis the actual append primitive and is allowed in inner-loop appends (and forQuantumCircuitto assume that it's callable from other methods), so it's important that the "ensure built" check happens there, not inappend.Details and comments
Fix #11180.