Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move one last release note for 0.45.0 #11060

Merged
merged 2 commits into from
Oct 20, 2023
Merged

Move one last release note for 0.45.0 #11060

merged 2 commits into from
Oct 20, 2023

Conversation

mtreinish
Copy link
Member

Summary

In the lead up to the 0.45.0rc1 release we used the merge queue to pipeline the last 2 PRs that merged for the tag. However, this resulted in a single release note file merging before we could move it into the 0.45/ subdirectory. This commit fixes this so that the final PR for 0.45.0rc1 is correctly grouped in the 0.45 release notes subdirectory.

Details and comments

In the lead up to the 0.45.0rc1 release we used the merge queue to
pipeline the last 2 PRs that merged for the tag. However, this resulted
in a single release note file merging before we could move it into the
0.45/ subdirectory. This commit fixes this so that the final PR for
0.45.0rc1 is correctly grouped in the 0.45 release notes subdirectory.
@mtreinish mtreinish added stable backport potential The bug might be minimal and/or import enough to be port to stable Changelog: None Do not include in changelog labels Oct 19, 2023
@mtreinish mtreinish added this to the 0.45.0 milestone Oct 19, 2023
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6580982459

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 16 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.003%) to 86.89%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 4 90.91%
crates/qasm2/src/parse.rs 12 97.13%
Totals Coverage Status
Change from base Build 6580401125: -0.003%
Covered Lines: 73861
Relevant Lines: 85005

💛 - Coveralls

Copy link
Contributor

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ElePT ElePT added this pull request to the merge queue Oct 20, 2023
Merged via the queue into Qiskit:main with commit 7585bd5 Oct 20, 2023
13 checks passed
mergify bot pushed a commit that referenced this pull request Oct 20, 2023
In the lead up to the 0.45.0rc1 release we used the merge queue to
pipeline the last 2 PRs that merged for the tag. However, this resulted
in a single release note file merging before we could move it into the
0.45/ subdirectory. This commit fixes this so that the final PR for
0.45.0rc1 is correctly grouped in the 0.45 release notes subdirectory.

(cherry picked from commit 7585bd5)
github-merge-queue bot pushed a commit that referenced this pull request Oct 20, 2023
In the lead up to the 0.45.0rc1 release we used the merge queue to
pipeline the last 2 PRs that merged for the tag. However, this resulted
in a single release note file merging before we could move it into the
0.45/ subdirectory. This commit fixes this so that the final PR for
0.45.0rc1 is correctly grouped in the 0.45 release notes subdirectory.

(cherry picked from commit 7585bd5)

Co-authored-by: Matthew Treinish <[email protected]>
Co-authored-by: Jake Lishman <[email protected]>
@mtreinish mtreinish deleted the mv-relnote branch October 27, 2023 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants