-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build filter coupling map with mix ideal/physical targets (backport #11009) #11049
Conversation
* Fix build filter coupling map with mix ideal/physical targets This commit fixes a small issue in the Target.build_coupling_map method with filter_idle_qubits=True. Previously the internal method used to filter the idle qubits from the coupling map's creation was not accounting for the case that an instruction in the target could be ideal. This was never caught because normally if you have an ideal fixed width instruction in the target that is modelling a simulator which doesn't have any connectivity constraints and the function would never be called. But in targets that have a mix of both ideal globally defined and physical gates the filter code couldn't handle the None used to represent an ideal globally available gate. This commit fixes that handling to just ignore the global gate like the normal coupling map construction does. * Fix lint (cherry picked from commit 4dfcba2)
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 6630641889
💛 - Coveralls |
This PR is still due to be backported to |
This is an automatic backport of pull request #11009 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com