Fix bug in qs_decomposition #10850
Merged
Fix bug in qs_decomposition #10850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewinston
requested review from
alexanderivrii,
ShellyGarion,
a team and
ikkoham
as code owners
|
One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 6205919056
💛 - Coveralls |
1ucian0
added
the
Changelog: Bugfix
1ucian0
reviewed
Sep 22, 2023
1ucian0
added
the
stable backport potential
1ucian0
approved these changes
Oct 3, 2023
mergify bot
pushed a commit
that referenced
this pull request
Oct 3, 2023
* fix bug in qs_decomposition * reno --------- Co-authored-by: Luciano Bello <[email protected]> (cherry picked from commit dda063e)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 4, 2023
* fix bug in qs_decomposition * reno --------- Co-authored-by: Luciano Bello <[email protected]> (cherry picked from commit dda063e) Co-authored-by: ewinston <[email protected]>
rupeshknn
pushed a commit
to rupeshknn/qiskit
that referenced
this pull request
Oct 9, 2023
* fix bug in qs_decomposition * reno --------- Co-authored-by: Luciano Bello <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fixes #10787
Details and comments
The unitary described in this issue was causing a single 2q unitary to be generated in the quantum shannon decomposition, when opt_a2==True, which couldn't take advantage of this diagonal commutation optimization and would error. The fix instead leaves this as an undecomposed 2-qubit unitary gate.