Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate bind_parameters in favor of assign_parameters #10792

Merged
merged 12 commits into from
Sep 12, 2023
Merged

Deprecate bind_parameters in favor of assign_parameters #10792

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
62cb99f
Deprecate bind parameters
ElePT Sep 7, 2023
32ed8e1
Merge branch 'main' of https://github.com/ElePT/qiskit-terra into bin…
ElePT Sep 7, 2023
c232cc9
Replace bind in docstring
ElePT Sep 7, 2023
5eb7146
Test deprecation warning
ElePT Sep 7, 2023
5cbf14a
Remove bind_parameters in algorithms
ElePT Sep 7, 2023
5bee235
Update releasenotes/notes/deprecate-bind-parameters-283c94069e8a9142.…
ElePT Sep 7, 2023
5e52b56
Apply suggestions from code review
ElePT Sep 7, 2023
5cbe784
Fix conflict
ElePT Sep 7, 2023
b2cacd6
suppress warnings in test Parameter Expressions
ElePT Sep 7, 2023
8d17911
Add module to filter
ElePT Sep 8, 2023
61172e8
Add filter to context manager
ElePT Sep 11, 2023
df69283
Fix black
ElePT Sep 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions test/python/circuit/test_parameters.py
View file
Open in desktop
jakelishman marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -1277,6 +1277,12 @@ class TestParameterExpressions(QiskitTestCase):

supported_operations = [add, sub, mul, truediv]

def setUp(self):
super().setUp()
# TODO: delete once bind_parameters is removed from the codebase
# and related tests are also removed.
warnings.filterwarnings("ignore", category=DeprecationWarning)
jakelishman marked this conversation as resolved.
Show resolved Hide resolved

def test_compare_to_value_when_bound(self):
"""Verify expression can be compared to a fixed value
when fully bound."""
Expand Down