Fix warning on __qiskit_version__
#10686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The warning emitted by the `QiskitVersion` class that backs the `__qiskit_version__` variable was previously set to warn on instantiation, not usage. This caused the warning to trigger during library import, rather than at the site of usage.
|
One or more of the the following people are requested to review this:
|
mtreinish
added
the
stable backport potential
mtreinish
approved these changes
Aug 22, 2023
There was a problem hiding this comment.
This LGTM, in my review on #10242 I was mainly concerned at the time that it didn't show up on import. But I realize I missed the stacklevel kwarg there so it was never actually visible with the default filters and was always triggering. Thanks for catching and fixing this.
|
Yeah, I caught it because |
mergify bot
pushed a commit
that referenced
this pull request
Aug 22, 2023
* Fix warning on `__qiskit_version__` The warning emitted by the `QiskitVersion` class that backs the `__qiskit_version__` variable was previously set to warn on instantiation, not usage. This caused the warning to trigger during library import, rather than at the site of usage. * Add warning assertion to test (cherry picked from commit 4ab2ef8)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 22, 2023
* Fix warning on `__qiskit_version__` The warning emitted by the `QiskitVersion` class that backs the `__qiskit_version__` variable was previously set to warn on instantiation, not usage. This caused the warning to trigger during library import, rather than at the site of usage. * Add warning assertion to test (cherry picked from commit 4ab2ef8) Co-authored-by: Jake Lishman <[email protected]>
SamD-1998
pushed a commit
to SamD-1998/qiskit-terra
that referenced
this pull request
Sep 7, 2023
* Fix warning on `__qiskit_version__` The warning emitted by the `QiskitVersion` class that backs the `__qiskit_version__` variable was previously set to warn on instantiation, not usage. This caused the warning to trigger during library import, rather than at the site of usage. * Add warning assertion to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The warning emitted by the
QiskitVersionclass that backs the__qiskit_version__variable was previously set to warn on instantiation, not usage. This caused the warning to trigger during library import, rather than at the site of usage.Details and comments
Originally introduced in #10242.