Migrate translation stage to plugins #10621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the preset pass manager construction to only use plugins for the translation stage. To accomplish this the previously hard coded built-in translation methods, unroller, translator, and synthesis are migrated to be exposed as built-in plugins. This simplifies the preset pass manager construction as now the translation stage is solely built via plugins. Fixes Qiskit#9456
mtreinish
added
Changelog: None
|
One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 5857576511
💛 - Coveralls |
jakelishman
reviewed
Aug 21, 2023
It is documented here: https://qiskit.org/documentation/apidoc/transpiler_plugins.html#plugin-stages the names here are already covered there which is why I didn't do a release note. I added a release note for the |
jakelishman
approved these changes
Aug 21, 2023
mtreinish
added a commit
to raynelfss/qiskit
that referenced
this pull request
Aug 22, 2023
This commit changes the plugin construction logic slightly to adjust how the embedded translation stage is created. After Qiskit#10621 merged we only need to use the plugin interface to get the translation stage pass manager.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 22, 2023
* Initial: Optimization stage as a plugin. * CI: Added fix to preset_passmanager test * Simplify inner translation stage creation logic This commit changes the plugin construction logic slightly to adjust how the embedded translation stage is created. After #10621 merged we only need to use the plugin interface to get the translation stage pass manager. * Update documentation --------- Co-authored-by: Matthew Treinish <[email protected]>
SamD-1998
pushed a commit
to SamD-1998/qiskit-terra
that referenced
this pull request
Sep 7, 2023
This commit updates the preset pass manager construction to only use plugins for the translation stage. To accomplish this the previously hard coded built-in translation methods, unroller, translator, and synthesis are migrated to be exposed as built-in plugins. This simplifies the preset pass manager construction as now the translation stage is solely built via plugins. Fixes Qiskit#9456
SamD-1998
pushed a commit
to SamD-1998/qiskit-terra
that referenced
this pull request
Sep 7, 2023
* Initial: Optimization stage as a plugin. * CI: Added fix to preset_passmanager test * Simplify inner translation stage creation logic This commit changes the plugin construction logic slightly to adjust how the embedded translation stage is created. After Qiskit#10621 merged we only need to use the plugin interface to get the translation stage pass manager. * Update documentation --------- Co-authored-by: Matthew Treinish <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit updates the preset pass manager construction to only use plugins for the translation stage. To accomplish this the previously hard coded built-in translation methods, unroller, translator, and synthesis are migrated to be exposed as built-in plugins. This simplifies the preset pass manager construction as now the translation stage is solely built via plugins.
Details and comments
Fixes #9456