-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small doc formatting issues #10574
Small doc formatting issues #10574
Changes from 10 commits
ccf0c02
c46ca8f
de1ff79
e202f57
6284431
1587f82
d1836a9
a504bb0
d9aed42
6e7c566
468f8ee
6edba2b
86c9d37
430d0b3
16b75c7
c6af56c
10ccfb9
4c5a033
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,8 +17,8 @@ | |
|
||
.. currentmodule:: qiskit.dagcircuit | ||
|
||
DAG Circuits | ||
============ | ||
DAG (directed acyclic graph) Circuits | ||
===================================== | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's unusual to put the definition of an acronym in a title. Probably a bit better to say it as:
or have the title as "Circuits as Directed Acyclic Graphs" and define the "DAG" acronym in the prose. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. done in 430d0b3 |
||
|
||
.. autosummary:: | ||
:toctree: ../stubs/ | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -48,7 +48,7 @@ | |
|
||
|
||
class DAGDependency: | ||
"""Object to represent a quantum circuit as a directed acyclic graph | ||
"""Object to represent a quantum circuit as a DAG | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Personally I think using the full text here was clearer, but I don't feel strongly. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. done in 16b75c7 |
||
via operation dependencies (i.e. lack of commutation). | ||
|
||
The nodes in the graph are operations represented by quantum gates. | ||
|
@@ -143,7 +143,7 @@ def calibrations(self): | |
"""Return calibration dictionary. | ||
|
||
The custom pulse definition of a given gate is of the form | ||
{'gate_name': {(qubits, params): schedule}} | ||
``{'gate_name': {(qubits, params): schedule}}``. | ||
""" | ||
return dict(self._calibrations) | ||
|
||
|
@@ -530,8 +530,7 @@ def draw(self, scale=0.7, filename=None, style="color"): | |
'color' (default): color input/output/op nodes | ||
|
||
Returns: | ||
Ipython.display.Image: if in Jupyter notebook and not saving to file, | ||
otherwise None. | ||
Ipython.display.Image: if in Jupyter notebook and not saving to file, otherwise None. | ||
""" | ||
from qiskit.visualization.dag_visualization import dag_drawer | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -31,8 +31,8 @@ def pass_manager_drawer(pass_manager, filename=None, style=None, raw=False): | |
""" | ||
Draws the pass manager. | ||
|
||
This function needs `pydot <https://github.com/erocarrera/pydot>`__, which in turn needs | ||
`Graphviz <https://www.graphviz.org/>`__ to be installed. | ||
This function needs `pydot <https://github.com/pydot/pydot>`_, which in turn needs | ||
`Graphviz <https://www.graphviz.org/>`_ to be installed. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The double underscore is also fine here - the single creates a named hyperlink (so you could later use No need to change anything here - both are fine - just pointing out that you don't need to worry about this in the future. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. always learning new things. reverting in c6af56c so the diff is cleaner. |
||
|
||
Args: | ||
pass_manager (PassManager): the pass manager to be drawn | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a note, the leading
~
is not needed here as this simply truncates the path of the object. Since here there's no path, as you just used.<Object>
, there's nothing to truncate (but it's not harmful afaik so no need to change) 🙂There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done!