Reduce use of legacy CircuitInstruction formats
#10416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes (as best as our test suite touches) all uses of the implicit legacy tuple form of `CircuitInstruction` that have crept in since ea02667 (Qiskitgh-8093). The changes are largely just mechanical over to the new form.
jakelishman
added
type: qa
jakelishman
requested review from
a team,
alexanderivrii,
ShellyGarion,
woodsp-ibm and
ElePT
as code owners
|
One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 5532984588
💛 - Coveralls |
Cryoris
approved these changes
Jul 12, 2023
jakelishman
added a commit
to jakelishman/qiskit-terra
that referenced
this pull request
Jul 13, 2023
Commit e2674ce (Qiskitgh-10416) reduced usage of the legacy format for `CircuitInstruction` within Terra, but one of the changes meant that a previously valid input to a public API function became invalid. This caused Qiskit Experiments' CI to fail, and wasn't a valid change to Terra.
ElePT
pushed a commit
to ElePT/qiskit-algorithms-test
that referenced
this pull request
Jul 17, 2023
This removes (as best as our test suite touches) all uses of the implicit legacy tuple form of `CircuitInstruction` that have crept in since ea02667 (gh-8093). The changes are largely just mechanical over to the new form.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This removes (as best as our test suite touches) all uses of the implicit legacy tuple form of
CircuitInstructionthat have crept in since ea02667 (gh-8093). The changes are largely just mechanical over to the new form.Details and comments
This PR doesn't propose the deprecation of the legacy interface yet. At the very least, that should come early in the cycle for a Terra version, and we know there to be uses in downstream Qiskit projects (Aer and Experiments each have a couple of fairly minor instances) that we can mitigate first.