Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate complex amp support for ScalableSymbolicPulse #10357

Merged
merged 8 commits into from
Jul 5, 2023
Merged

Deprecate complex amp support for ScalableSymbolicPulse #10357

merged 8 commits into from
Jul 5, 2023

Conversation

TsafrirA
Copy link
Collaborator

Summary

We deprecate the support for complex amp in the initialization of ScalableSymbolicPulse.

Details and comments

PR #9002 (and later #9871) issued PendingDeprecationWarnings for initialization of ScalableSymbolicPulse (and particularly the library pulses which rely on it) with complex amp. The alternative amp, angle representation was introduced then. This PR promotes the warning to a deprecation warning.

@TsafrirA TsafrirA requested review from a team, eggerdj and wshanks as code owners June 29, 2023 07:45
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core
  • @nkanazawa1989

@coveralls
Copy link

coveralls commented Jun 29, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5461949464

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 29 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.006%) to 85.963%
Files with Coverage Reduction New Missed Lines %
crates/accelerate/src/vf2_layout.rs 1 94.74%
qiskit/transpiler/passes/synthesis/unitary_synthesis.py 1 90.18%
crates/accelerate/src/sabre_swap/layer.rs 4 97.32%
crates/qasm2/src/lex.rs 5 90.63%
crates/qasm2/src/parse.rs 18 95.71%
Totals Coverage Status
Change from base Build 5451491224: -0.006%
Covered Lines: 71671
Relevant Lines: 83374
💛 - Coveralls

nkanazawa1989
nkanazawa1989 reviewed Jun 29, 2023
View reviewed changes
Copy link
Contributor

@nkanazawa1989 nkanazawa1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks almost good to me. Just a few minor suggestions.

qiskit/pulse/library/symbolic_pulses.py Outdated Show resolved Hide resolved
releasenotes/notes/deprecate-complex-amp-41381bd9722bc878.yaml Outdated Show resolved Hide resolved
releasenotes/notes/deprecate-complex-amp-41381bd9722bc878.yaml Outdated Show resolved Hide resolved
Eric-Arellano
Eric-Arellano reviewed Jun 29, 2023
View reviewed changes
Copy link
Collaborator

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the ping!

qiskit/pulse/library/symbolic_pulses.py Show resolved Hide resolved
qiskit/pulse/library/symbolic_pulses.py Outdated Show resolved Hide resolved
nkanazawa1989
nkanazawa1989 reviewed Jul 4, 2023
View reviewed changes
Copy link
Contributor

@nkanazawa1989 nkanazawa1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor suggestions for type hints, but this is almost good to go.

qiskit/pulse/library/symbolic_pulses.py Outdated Show resolved Hide resolved
nkanazawa1989
nkanazawa1989 approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@nkanazawa1989 nkanazawa1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @TsafrirA this looks good to go.

@nkanazawa1989 nkanazawa1989 added this pull request to the merge queue Jul 5, 2023
Merged via the queue into Qiskit:main with commit cd770b5 Jul 5, 2023
@coruscating coruscating mentioned this pull request Jul 7, 2023
Merged
github-merge-queue bot pushed a commit to qiskit-community/qiskit-experiments that referenced this pull request Jul 7, 2023
@coruscating
Update tests with complex amp pulses (#1217)
ad8aa79 
### Summary

This PR removes complex amplitudes from pulses in tests after
Qiskit/qiskit#10357.
mergify bot pushed a commit to qiskit-community/qiskit-experiments that referenced this pull request Aug 25, 2023
@coruscating @mergify
Update tests with complex amp pulses (#1217)
9af8dc9 
### Summary

This PR removes complex amplitudes from pulses in tests after
Qiskit/qiskit#10357.

(cherry picked from commit ad8aa79)

# Conflicts:
#	test/calibration/test_calibrations.py
@TsafrirA TsafrirA deleted the ComplexAmpDeprecation branch November 13, 2023 11:13
This was referenced Nov 15, 2023
Closed
Merged
@TsafrirA TsafrirA mentioned this pull request Dec 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eric-Arellano Eric-Arellano Eric-Arellano left review comments

@1ucian0 1ucian0 1ucian0 left review comments

@nkanazawa1989 nkanazawa1989 nkanazawa1989 approved these changes

@eggerdj eggerdj Awaiting requested review from eggerdj eggerdj is a code owner

@wshanks wshanks Awaiting requested review from wshanks wshanks is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@TsafrirA @qiskit-bot @coveralls @1ucian0 @wshanks @Eric-Arellano @nkanazawa1989