Fix Numpy 1.25 deprecations #10308
Merged
Fix Numpy 1.25 deprecations #10308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of the effects we see are because of the removal of various aliases (`np.product` being a common one), but the new warning on implicit conversion of size-1 arrays to scalars that was initially found in parts of c463b3c has reared its head again too.
jakelishman
added
type: qa
jakelishman
requested review from
a team,
alexanderivrii,
ShellyGarion,
ikkoham and
woodsp-ibm
as code owners
|
One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 5311917846
💛 - Coveralls |
mtreinish
approved these changes
Jun 19, 2023
Comment on lines
+92
to
+96
| lhs = math.sin(angle / 2) | ||
|
|
||
| def objective(phi): | ||
| rhs = 2 * math.sin(phi / 2) ** 2 | ||
| rhs *= math.sqrt(1 - math.sin(phi / 2) ** 4) | ||
| lhs = math.sin(angle / 2) | ||
| return rhs - lhs | ||
| sin_sq = np.sin(phi / 2) ** 2 | ||
| return 2 * sin_sq * np.sqrt(1 - sin_sq**2) - lhs |
There was a problem hiding this comment.
I assume this was the place with the implicit scalar conversion was emitting a deprecation warning because of the switch from math.sin() and math.sqrt() to np.sin() and np.sqrt()`.
There was a problem hiding this comment.
This is one of them, yeah. I didn't realise I'd screwed with the implementation as much as that - I think I was thinking about reducing the increased overhead from switching back to Numpy dispatchers. I don't know enough about the internals of how Scipy's fsolve to know for sure what's safe as a return value, but it definitely puts in arrays.
jakelishman
added a commit
that referenced
this pull request
Jun 19, 2023
Most of the effects we see are because of the removal of various aliases (`np.product` being a common one), but the new warning on implicit conversion of size-1 arrays to scalars that was initially found in parts of c463b3c has reared its head again too. (cherry picked from commit 364d6fd) Co-authored-by: Jake Lishman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Most of the effects we see are because of the removal of various aliases (
np.productbeing a common one), but the new warning on implicit conversion of size-1 arrays to scalars that was initially found in parts of c463b3c has reared its head again too.Details and comments
This is not a complete resolution of #10305 because of larger issues with correctness of the
Isometrycode triggered by Numpy 1.25. It should fix all the new deprecation warnings, though.