-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fake generic and modify tests #10266
Merged
kevinhartman
merged 65 commits into
Qiskit:main
from
MozammilQ:add_FakeGeneric_and_modify_tests
Jan 29, 2024
Merged
Changes from 54 commits
Commits
Show all changes
65 commits
Select commit
Hold shift + click to select a range
060d56b
Added a FakeGeneric BackendV2 backend, this is just a bare minimum wo…
MozammilQ ae26ee5
All FakeBackends (like FakeMelbourne, FakeBoeblingen ,etc) is replace…
MozammilQ c15254e
relocated FakeGeneric in fake_provider directory; replaced if-elif wi…
MozammilQ 7f544d4
added tests for FakeGeneric
MozammilQ c864645
This commit just reformats test_transpiler.py fake_generic.py and tes…
MozammilQ 1531e84
Update qiskit/providers/fake_provider/fake_generic.py
MozammilQ bf91f35
Update qiskit/providers/fake_provider/fake_generic.py
MozammilQ c34316a
Update test/python/providers/fake_provider/test_fake_generic.py
MozammilQ dc24618
Update test/python/providers/fake_provider/test_fake_generic.py
MozammilQ 0e57867
Merge branch 'main' into add_FakeGeneric_and_modify_tests
ElePT 02099a0
Fix some tests
ElePT 680c3ce
Add calibration schedules, fix transpiler tests
ElePT 6131e31
Fix lint
ElePT 04914f2
Refactor, add pulse functionality
ElePT 2523707
Latest updates to FakeGeneric
ElePT 7ec720d
Fix some unit tests
ElePT 8ce51ee
Fix some unit tests
ElePT 5592167
Fix tests, lint, refactor
ElePT f2f3320
Remove unused inputs
ElePT 22de937
Make calibrations optional
ElePT 550234b
Attempt to speed up test: only add calibrations if option enabled
ElePT 4fdf780
Revert some tests to V1
ElePT d2c1ba9
Fix conflict
ElePT 177953b
Refactor FakeGeneric
ElePT 96c46e1
Update unit test
ElePT 242d5fb
Rename supported instructions to operations, fix tests
ElePT e8305e3
Restore vf2postlayout test to V1
ElePT be2393b
Add pulse test to validate pulse capabilities of new fake backend
ElePT a6b3fe6
Update docs, fix lint
ElePT fbd1aad
Avoid set for basis gates to allow reproducibility in the error/durat…
ElePT 349141c
Merge branch 'main' into add_FakeGeneric_and_modify_tests
ElePT 6f3bb4b
Update calibrations
ElePT c9c72e1
Merge branch 'main' of https://github.com/ElePT/qiskit-terra into add…
ElePT cacd296
Merge branch 'add_FakeGeneric_and_modify_tests' of https://github.com…
ElePT ba14dc1
Fix transpiler test
ElePT 5b87345
Add run test to confirm noise defaults
ElePT 01343ad
Add CZ to basis gates, dtm, update backend names, fix docs
ElePT 982deb7
Remove GenericTarget, add default for basis_gates, remove supported_o…
ElePT d69c01d
Merge branch 'main' into add_FakeGeneric_and_modify_tests
ElePT 09bc015
Apply review comments, modify calibrate_instructions to avoid public …
ElePT e0c5aa7
New name proposal
ElePT 6b0817a
Fix conflict
ElePT 12e253d
Fix lint and test
ElePT 0db8035
Fix comment
ElePT abef228
Apply Kevin's suggestions to extract defaults from class
ElePT 0d303bb
Make defaults private
ElePT 9e276e9
Fix lint
ElePT e98f059
Revert previous 3 comments.
ElePT d44a517
Privatize GenericFakeBackend
ElePT a54fb64
Remove from docs
ElePT 99c643f
Revert privatization
ElePT de63a9d
Apply review comments
ElePT fca016a
Add reno
ElePT de5bc0e
Fix lint
ElePT 099143f
Apply suggestions from Matt's code review
ElePT 54496db
Apply comments from code review
ElePT 0e00b22
Fix conflict
ElePT fe37393
Fix lint
ElePT a36acaf
Rename to GenericBackendV2 and adjust docs.
ElePT f1816ea
Fix lint
ElePT 741831e
Apply comments from code review
ElePT ee588cc
It's not 2023 anymore
ElePT 93cdb36
Merge branch 'main' into add_FakeGeneric_and_modify_tests
ElePT cba3eba
Fix conflict
ElePT 72d1dee
Fix test conflict.
kevinhartman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the interest of time we should leave this for after the release candidate is shipped, but I think it would be good to get some proper top-level documentation and examples written for how people should build and use these backends. We want to show people best practices for testing their compilation / whatever workloads before shipping them off to real hardware.