Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
__qiskit_version__ deprecation #10242
__qiskit_version__ deprecation #10242
Changes from 12 commits
3b97cf3
251c13b
2100746
c527232
d30025c
6764115
db99e1d
c32a965
d0d8588
a846ffe
bab5901
51aa73a
783ef27
2fa746e
ef07de4
3d39cdb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at this with fresh eyes my concern here is that the module name in
sys.modules
isn't necessarily going to be the package name that importlib.metadata will find. The best example of this is actuallyqiskit
, if you just have terra installed you would need to callmetadata("qiskit-terra")
notmetadata("qiskit")
to get the installed package version for theqiskit
module insys.modules
.I think it might be better to do:
so it just uses the version reported in the
__version__
attribute.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably be
qiskit_module
right, because if a version can't be found forqiskit_module
you don't want to invalidate the qiskit package versio.