Replace assert in tests with unittest methods
#10136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cryoris
requested review from
a team,
ikkoham,
woodsp-ibm and
ElePT
as code owners
|
One or more of the the following people are requested to review this:
|
Cryoris
added
Changelog: None
Pull Request Test Coverage Report for Build 5045808939
💛 - Coveralls |
ElePT
previously approved these changes
May 22, 2023
Comment on lines
-57
to
-58
| from scipy.optimize import rosen | ||
| from qiskit.utils import algorithm_globals |
There was a problem hiding this comment.
These local imports looked strange to me too.
jakelishman
reviewed
May 22, 2023
Co-authored-by: Jake Lishman <[email protected]>
jakelishman
approved these changes
May 22, 2023
king-p3nguin
pushed a commit
to king-p3nguin/qiskit-terra
that referenced
this pull request
May 22, 2023
* Replace `assert` with unittest methods * Update test/python/algorithms/optimizers/test_umda.py Co-authored-by: Jake Lishman <[email protected]> --------- Co-authored-by: Jake Lishman <[email protected]>
ElePT
pushed a commit
to ElePT/qiskit
that referenced
this pull request
Jun 27, 2023
* Replace `assert` with unittest methods * Update test/python/algorithms/optimizers/test_umda.py Co-authored-by: Jake Lishman <[email protected]> --------- Co-authored-by: Jake Lishman <[email protected]>
ElePT
pushed a commit
to ElePT/qiskit-algorithms-test
that referenced
this pull request
Jul 17, 2023
* Replace `assert` with unittest methods * Update test/python/algorithms/optimizers/test_umda.py Co-authored-by: Jake Lishman <[email protected]> --------- Co-authored-by: Jake Lishman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Mainly a follow-up to #8695, where we noticed some plain
assertstatements used instead of the appropriateunittestmethods. Also replaces those in some other tests and removes a dangling commentedassertline.Details and comments