-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CITATION.bib from metapackage #10111
Conversation
One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 4973761157
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I grepped terra for .bib
, and this is indeed the only occurrence. The only change I suggest is editing .md
-> .bib
in this PR's title, to avoid confusion when viewing the shortlog.
@misc{Qiskit, | ||
author = {{Qiskit contributors}}, | ||
title = {Qiskit: An Open-source Framework for Quantum Computing}, | ||
year = {2023}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comes from the original file in qiskit-metapacage, but why is the year 2023? and do we plan to update every year?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would expect this to match the version users cite -- so I would think we have to update it every year. But I also don't know what the common practice for this is 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that the Zenodo DOI in the citation will point to the latest release, so the year of the most recent release should be correct in general, I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems fine to me. We'll potentially want to have qiskit-bot update the year for us on the first release of a new year, if necessary, but any change on that front is done elsewhere, and might depend on what automation we remain with after the repository switch-over.
Originally posted by @garrison in Qiskit/qiskit-metapackage#1722 (comment)
This is related with
RFC 0011