Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CITATION.bib from metapackage #10111

Merged
merged 1 commit into from
May 15, 2023
Merged

CITATION.bib from metapackage #10111

merged 1 commit into from
May 15, 2023

Conversation

1ucian0
Copy link
Member

@1ucian0 1ucian0 commented May 14, 2023

Originally posted by @garrison in Qiskit/qiskit-metapackage#1722 (comment)

Just noticed that CITATION.bib needs to move as well. Otherwise, the link from the Terra README will be broken after qiskit-terra -> qiskit.

This is related with RFC 0011

@1ucian0 1ucian0 requested a review from a team as a code owner May 14, 2023 18:10
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4973761157

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 21 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-0.04%) to 85.862%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/expr.rs 1 93.76%
qiskit/extensions/quantum_initializer/squ.py 2 80.0%
crates/accelerate/src/vf2_layout.rs 3 94.74%
crates/accelerate/src/sabre_swap/layer.rs 4 97.32%
crates/qasm2/src/lex.rs 5 90.63%
crates/qasm2/src/parse.rs 6 97.58%
Totals Coverage Status
Change from base Build 4961195397: -0.04%
Covered Lines: 70814
Relevant Lines: 82474

💛 - Coveralls

Copy link
Member

@garrison garrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I grepped terra for .bib, and this is indeed the only occurrence. The only change I suggest is editing .md -> .bib in this PR's title, to avoid confusion when viewing the shortlog.

@1ucian0 1ucian0 changed the title CITATION.md from metapackage CITATION.bib from metapackage May 15, 2023
@misc{Qiskit,
author = {{Qiskit contributors}},
title = {Qiskit: An Open-source Framework for Quantum Computing},
year = {2023},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comes from the original file in qiskit-metapacage, but why is the year 2023? and do we plan to update every year?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would expect this to match the version users cite -- so I would think we have to update it every year. But I also don't know what the common practice for this is 🙂

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that the Zenodo DOI in the citation will point to the latest release, so the year of the most recent release should be correct in general, I think.

Copy link
Member

@jakelishman jakelishman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine to me. We'll potentially want to have qiskit-bot update the year for us on the first release of a new year, if necessary, but any change on that front is done elsewhere, and might depend on what automation we remain with after the repository switch-over.

@jakelishman jakelishman added this pull request to the merge queue May 15, 2023
@jakelishman jakelishman added documentation Something is not clear or an error documentation Changelog: None Do not include in changelog labels May 15, 2023
Merged via the queue into Qiskit:main with commit 86e0f82 May 15, 2023
king-p3nguin pushed a commit to king-p3nguin/qiskit-terra that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog documentation Something is not clear or an error documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants