Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off CI for forks #10078

Merged
merged 1 commit into from
May 8, 2023
Merged

Turn off CI for forks #10078

merged 1 commit into from
May 8, 2023

Conversation

Eric-Arellano
Copy link
Collaborator

Summary

Most people agree that GitHub made a mistake by having forks run CI both on the fork and in the upstream repository. It wastes computing resources (which has a real environmental cost!). In this repo in particular, the nightly integration tests have been failing for me.

Details and comments

If people really want to run CI in their fork, they can always modify their fork's config to revert this change.

@Eric-Arellano Eric-Arellano requested a review from mtreinish May 4, 2023 17:02
@Eric-Arellano Eric-Arellano requested a review from a team as a code owner May 4, 2023 17:02
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4885330331

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 29 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+0.03%) to 85.897%

Files with Coverage Reduction New Missed Lines %
qiskit/transpiler/passes/synthesis/unitary_synthesis.py 1 90.46%
crates/qasm2/src/lex.rs 2 90.89%
qiskit/extensions/quantum_initializer/squ.py 2 80.0%
crates/accelerate/src/sabre_swap/layer.rs 4 97.32%
crates/accelerate/src/vf2_layout.rs 8 86.44%
crates/qasm2/src/parse.rs 12 97.11%
Totals Coverage Status
Change from base Build 4876894924: 0.03%
Covered Lines: 71239
Relevant Lines: 82935

💛 - Coveralls

Copy link
Member

@kdk kdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I haven't seen any reason to run these tests on forks.

@kdk kdk added this pull request to the merge queue May 8, 2023
Merged via the queue into Qiskit:main with commit 3499bfa May 8, 2023
@Eric-Arellano Eric-Arellano deleted the turn-off-forks branch May 8, 2023 19:59
king-p3nguin pushed a commit to king-p3nguin/qiskit-terra that referenced this pull request May 22, 2023
github-merge-queue bot pushed a commit to qiskit-community/qiskit-experiments that referenced this pull request Dec 18, 2023
Follows Qiskit/qiskit#10078. I don't see a
reason to run CI on forks by default.
nkanazawa1989 pushed a commit to nkanazawa1989/qiskit-experiments that referenced this pull request Jan 17, 2024
Follows Qiskit/qiskit#10078. I don't see a
reason to run CI on forks by default.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants