Ruff enable flake8-comprehensions (C4) (#10339)

* Ruff enable flake8-comprehensions (C4) * add symbolic ruff rule id --------- Co-authored-by: John Lapeyre <[email protected]>
Qiskit · Jun 28, 2023 · b73115f · b73115f
1 parent 2ca4698
commit b73115f
Show file tree

Hide file tree

Showing 7 changed files with 7 additions and 6 deletions.
diff --git a/examples/python/initialize.py b/examples/python/initialize.py
@@ -55,7 +55,7 @@
 
 # Desired vector
 print("Desired probabilities: ")
-print(list(map(lambda x: format(abs(x * x), ".3f"), desired_vector)))
+print([format(abs(x * x), ".3f") for x in desired_vector])
 
 # Initialize on local simulator
 sim_backend = BasicAer.get_backend("qasm_simulator")

diff --git a/pyproject.toml b/pyproject.toml
@@ -32,6 +32,7 @@ repair-wheel-command = "cp {wheel} {dest_dir}/. && pipx run abi3audit --strict -
 
 [tool.ruff]
 select = [
+  "C4",  # category: flake8-comprehensions
   "F631",
   "F632",
   "F634",

diff --git a/qiskit/pulse/macros.py b/qiskit/pulse/macros.py
@@ -176,7 +176,7 @@ def _measure_v2(
     meas_group = set()
     for qubit in qubits:
         meas_group |= set(meas_map[qubit])
-    meas_group = sorted(list(meas_group))
+    meas_group = sorted(meas_group)
 
     meas_group_set = set(range(max(meas_group) + 1))
     unassigned_qubit_indices = sorted(set(meas_group) - qubit_mem_slots.keys())

diff --git a/qiskit/qobj/converters/pulse_instruction.py b/qiskit/qobj/converters/pulse_instruction.py
@@ -898,7 +898,7 @@ def _convert_parametric_pulse(
         try:
             pulse_name = instruction.label
         except AttributeError:
-            sorted_params = sorted(tuple(instruction.parameters.items()), key=lambda x: x[0])
+            sorted_params = sorted(instruction.parameters.items(), key=lambda x: x[0])
             base_str = "{pulse}_{params}".format(
                 pulse=instruction.pulse_shape, params=str(sorted_params)
             )

diff --git a/qiskit/transpiler/coupling.py b/qiskit/transpiler/coupling.py
@@ -475,7 +475,7 @@ def connected_components(self) -> List["CouplingMap"]:
         output_list = []
         for component in components:
             new_cmap = CouplingMap()
-            new_cmap.graph = self.graph.subgraph(list(sorted(component)))
+            new_cmap.graph = self.graph.subgraph(sorted(component))
             output_list.append(new_cmap)
         return output_list
 

diff --git a/qiskit/transpiler/passes/layout/disjoint_utils.py b/qiskit/transpiler/passes/layout/disjoint_utils.py
@@ -176,7 +176,7 @@ def separate_dag(dag: DAGCircuit) -> List[DAGCircuit]:
     connected_components = rx.weakly_connected_components(im_graph)
     component_qubits = []
     for component in connected_components:
-        component_qubits.append(set(qubit_map[x] for x in component))
+        component_qubits.append({qubit_map[x] for x in component})
 
     qubits = set(dag.qubits)
 

diff --git a/test/python/pulse/test_block.py b/test/python/pulse/test_block.py
@@ -959,7 +959,7 @@ def _filter_and_test_consistency(
         excluded = sched_blk.exclude(*args, **kwargs)
 
         def list_instructions(blk: pulse.ScheduleBlock) -> List[pulse.Instruction]:
-            insts = list()
+            insts = []
             for element in blk.blocks:
                 if isinstance(element, pulse.ScheduleBlock):
                     inner_insts = list_instructions(element)
-Original file line number
+Diff line change
@@ Expand Up @@
     [tool.ruff]
     select = [
+      "C4",  # category: flake8-comprehensions
       "F631",
       "F632",
       "F634",
@@ Expand Down @@