Skip to content

Commit

Permalink
Pin rust compiler version to 1.73 for wheel builds (#11267)
Browse files Browse the repository at this point in the history
* Pin rust compiler version to 1.73 for wheel builds

With the release 1.74 on 11-16-2023 the minimum supported macOS version
by the Rust compiler is 10.12. For the 0.45.x release series we still
support macOS 10.9 (this will change in 1.0 see #10902). To faciliate
still publishing wheels that will support macOS 10.9 for any future
bugfix releases on 0.45.x release series (and 0.46.x too) this commit
pins the rust toolchain version we use to 1.73 which is the last
release that support 10.9.

* DNM: test wheel builds

* Add win32 target

* Only pin macOS version

* Fix syntax error

* Revert "DNM: test wheel builds"

This reverts commit 9cbd70f.

* Use stable on linux
  • Loading branch information
mtreinish authored Nov 24, 2023
1 parent 4a5982a commit 310c457
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
3 changes: 3 additions & 0 deletions .github/workflows/wheels.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@ jobs:
with:
python-version: '3.10'
- uses: dtolnay/rust-toolchain@stable
if: runner.os != 'macOS'
- uses: dtolnay/[email protected]
if: runner.os == 'macOS'
- name: Build wheels
uses: pypa/[email protected]
- uses: actions/upload-artifact@v3
Expand Down
1 change: 1 addition & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ repair-wheel-command = "auditwheel repair -w {dest_dir} {wheel} && pipx run abi3

[tool.cibuildwheel.macos]
repair-wheel-command = "delocate-wheel --require-archs {delocate_archs} -w {dest_dir} -v {wheel} && pipx run abi3audit --strict --report {wheel}"
environment = 'RUSTUP_TOOLCHAIN="1.73"'

[tool.cibuildwheel.windows]
repair-wheel-command = "cp {wheel} {dest_dir}/. && pipx run abi3audit --strict --report {wheel}"
Expand Down

0 comments on commit 310c457

Please sign in to comment.