-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): bump pin on numpy requirement #1524
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First of all thank you so much for your contribution @robertodr
client
is our library used in our ray-node
image. Taking this into account numpy
is a library very used in our entire stack so I don't think we can remove it so easily because it could be needed to run other functions that count with it.
My proposal would be to follow a similar requirement as Qiskit:
numpy>=1.17,<3
So v2 would be supported.
@Tansito I would be happy with lifting the version pinning as you suggest. However, keeping a package you don't directly depend on in your |
Well, our use case it's a bit special due to the usage that we are doing with our docker image. But thinking a bit more about it I think you are right here and it's better to move it to our -dev dependencies. Could you update your change with the same restriction as qiskit as we were discussing above? Apart from that I think everything is fine 👍 |
It seems there is an error in one of the tests @robertodr , I will take a look into it and let you know |
@robertodr from the tests it seems We will take a look in the meantime what dependency requires to have |
sorry @robertodr it seems we continue with some incompatibilities, tomorrow I will take a look and let you know 🙏 |
@robertodr I could finally identify the problem and we will take a look as soon as we can. I created this issue to keep you updated about the advances: #1533 I will close this PR in the meantime and open a new one as soon as we have it fix it! |
Ok thanks. Will subscribe to that issue |
Summary
NumPy is only needed to run tests and examples. I've moved it to
requirements-dev.txt
as otherwise downstream packages cannot update to NumPy >=2.0.Details and comments