-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updating docs notebook dependencies + use latest fakebackend #1227
Conversation
@Tansito the Notebook execution fails on LocalProvider (Notebook LocalProvider tests) but passes on ServerlessProvider (Test QS on Kubernetes). |
Sure, I will take a look as soon as I can, @david-alber 👍 |
I was taking a look but to be honest I didn't find where the problem could be. @akihikokuroda could you bring us some help here? 4 eyes can see better than two 🙏 In the meantime, @david-alber , could you updated this workflow too? |
The difference between LocalProvider tests and Test QS on Kubernetes is the way to install dependency python libraries including qiskit modules. The Test QS Kubernetes specifies and installs them in the workflow file. The LocalProvider does it using the requirement.txt file. Here is the Test QS Kubernetes workflow
here is the contents of the requrements.txt file.
The requirements.txt probably need to be updated. |
@akihikokuroda @Tansito As recommended by the Qiskit Migration Guided I checked if the client/requirements.txt introduce a qiskit-terra dependency. I found it puzzling that the notebooks |
@@ -31,8 +31,8 @@ def test_transpile(self): | |||
circuit1 = random_circuit(5, 3) | |||
circuit2 = random_circuit(5, 3) | |||
|
|||
backend1 = FakeAlmadenV2() | |||
backend2 = FakeBrooklynV2() | |||
backend1 = GenericBackendV2(num_qubits=5) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure it matters for these tests, but I found this replacement list for deprecated fake providers, FakeAlmadenV2
is now Fake20QV1
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @karlaspuldaro,
I decided to use the GenericBackendV2
because it seems to be the only qiskit.providers.fake_provider
that is not a legacy interface.
Do you see an advantage of using Fake20QV1
over GenericBackendV2
?
I think either one would be fine 😃.
I might find the cause of the error. In the 03_dependencies.ipynb It specifies additional dependencies for the program.
The config I hope this is it. |
The additional dependencies are install in the local environment for the LocalProvider. Creating a virtual environment for each job execution in the LocalProvider may be a good enhancement. |
This indeed seems to be it :). Very well spotted @akihikokuroda. Thanks!!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@david-alber Thanks for your work. LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much @david-alber , @akihikokuroda , everything looks good to mee too.
Btw @david-alber did you have the opportunity to review @karlaspuldaro comment? In case it would be better to use one or another solution (no problem if you don't know, I can take a look later 😄 )
@Tansito @karlaspuldaro to be honest I can't say if one or the other is better. To me, it seems that to test the transpiler both would do the job 😇. I chose |
For me your answer is fair enough, @david-alber . Thank you so much for this! ❤️ If there was more doubts @akihikokuroda and I can solve them in another pull request / issue (I will ask internally in any case 😄) |
jup sounds good ❤️ 🥳. Thanks y'all for working together on this one 🥂!!! |
Summary
Closes #1224
Making the PR checks stages Test QS on Kubernetes, Notebook LocalProvider tests and Client verify process Qiskit 1.0.0 compatible by updating the dependencies for this stage:
qiskit-ibmq-provider
dependencyqiskit-aer
,circuit-knitting-toolbox
to latest versionsUsing GenericBackendV2 as fake backend as it is Qiskit 1.0.0 compatible, see here.
Details and comments
See failed tests in PR #1205