Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Sphinx theme #18

Merged
merged 2 commits into from
Oct 19, 2023
Merged

Conversation

arnaucasau
Copy link
Contributor

@arnaucasau arnaucasau commented Sep 25, 2023

Summary

Updates to new Ecosystem theme.

For more information: Qiskit/qiskit_sphinx_theme#232

@arnaucasau arnaucasau marked this pull request as draft September 27, 2023 07:26
docs/index.rst Outdated
@@ -13,6 +18,7 @@ parsing frameworks and so on is far more complex for code brought into Qiskit,
as the stability guarantees are much stronger.

.. contents::
:class: this-will-duplicate-information-and-it-is-still-useful-here
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this used for debug?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is used to avoid the warnings when using a ToC. This version of the Sphinx theme uses Furo and we get a warning using the contents directive when the right sidebar provides the same information already. To avoid this, you can delete the ToC or use :class: this-will-duplicate-information-and-it-is-still-useful-here.

Here you can see the issue pradyunsg/furo#88

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The discussion in that Furo issue suggests that the table of contents here isn't necessary any more. If you're trying to port this documentation to a new theme with different structural requirements, please can you make sure any requirements of the new theme are fully satisfied?

This ToC was originally added because Sphinx needs a top-level to define the structure, but it looks like you've added another one, which would render this obsolete.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, and I just double checked with @Eric-Arellano and I will delete that contents directive in the next commit. Thank you for the comment.

@arnaucasau arnaucasau marked this pull request as ready for review October 10, 2023 15:47
@jakelishman jakelishman merged commit d3bbc9c into Qiskit:main Oct 19, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants