Skip to content
This repository has been archived by the owner on Aug 19, 2023. It is now read-only.

Remove unused docs images #1749

Merged
merged 3 commits into from
Jun 5, 2023
Merged

Remove unused docs images #1749

merged 3 commits into from
Jun 5, 2023

Conversation

Eric-Arellano
Copy link
Collaborator

@Eric-Arellano Eric-Arellano commented Jun 1, 2023

These are all unused. Determined by running this script to run ripgrep:

import os
import subprocess

def rg_search(term):
    result = subprocess.run(['rg', term, "qiskit-metapackage", "qiskit-terra"], stdout=subprocess.PIPE, stderr=subprocess.PIPE)
    return not bool( result.stdout)

with open("terms.txt", "r") as f:
    for line in f:
        term = line.strip() # Remove newline characters
        if rg_search(term):
            print(term)

With these terms:

aer.png
aqua.png
binary.png
contributor-flowchart.svg
favicon.ico
hardware.png
ignis.png
logo.png
metal.png
noise_cancel.png
qiskit.png
qiskit_main.svg
qiskit_nutshell.png
quantum_interference.png
system_error.png
system_one.jpeg
teleportation.png
teleportation_detailed.png
terra.png
getting_started_0.png
getting_started_1.png
ignis_overview.png
install_0.png
qiskit-framework.png

--

This also moves two images from _static to images. There was no good reason to have them in separate folders. This change simplifies our setup.

@Eric-Arellano Eric-Arellano requested a review from 1ucian0 June 2, 2023 14:12
@1ucian0 1ucian0 merged commit c591e8f into Qiskit:master Jun 5, 2023
@Eric-Arellano Eric-Arellano deleted the rm-images branch June 5, 2023 11:34
1ucian0 pushed a commit that referenced this pull request Jun 7, 2023
We now have `-W` enabled in both Terra and qiskit-tutorials. So, there
is no risk that warnings from their repo will result in warnings in this
repo.

This also adds back `binary.png`, which I incorrectly removed in
#1749 because I didn't
realize I needed to check the tutorials repo for images.
Eric-Arellano added a commit that referenced this pull request Jul 13, 2023
The main change is the new `qiskit` theme based on Furo, but we don't
yet activate that.

Otherwise, the only relevant change is simplifying the API for custom
directives. And fixing 404 errors about missing Thebe files.

--

This also fixes the images not working for two `qiskit-card`s, which I
accidentally broke in
#1749. For
`qiskit-card`, the images apparently must live in the `_static` folder
for Sphinx to know to include the images in the final build. This is
unlike when we normally use images.
jakelishman pushed a commit to jakelishman/qiskit-terra that referenced this pull request Aug 11, 2023
* Remove unused docs images

* Move images from _static to images/

---------

Co-authored-by: Luciano Bello <[email protected]>
jakelishman pushed a commit to jakelishman/qiskit-terra that referenced this pull request Aug 11, 2023
The main change is the new `qiskit` theme based on Furo, but we don't
yet activate that.

Otherwise, the only relevant change is simplifying the API for custom
directives. And fixing 404 errors about missing Thebe files.

--

This also fixes the images not working for two `qiskit-card`s, which I
accidentally broke in
Qiskit/qiskit-metapackage#1749. For
`qiskit-card`, the images apparently must live in the `_static` folder
for Sphinx to know to include the images in the final build. This is
unlike when we normally use images.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants