Skip to content
This repository has been archived by the owner on Aug 19, 2023. It is now read-only.

broken links in release notes #1739

Closed
1ucian0 opened this issue May 12, 2023 · 6 comments · Fixed by #1741
Closed

broken links in release notes #1739

1ucian0 opened this issue May 12, 2023 · 6 comments · Fixed by #1741
Assignees
Labels
documentation Something is not clear or error in description good first issue Good for newcomers

Comments

@1ucian0
Copy link
Member

1ucian0 commented May 12, 2023

This is a check of https://qiskit.org/documentation/release_notes.html on https://www.deadlinkchecker.com/ - May 12, 2023

100% scanned - 1530/1530 URLs checked, 1515 OK, 15 failed
 

Error URL Anchor Text Linked From
404 Not Found https://docs.scipy.org/doc/scipy/reference/optimize.minimize-lbfgsb.html. scipy docs https://qiskit.org/documentation/release_notes.html
403 Forbidden https://dl.acm.org/doi/10.1145/3445814.3446706 “Time-optimal qubit mapping” https://qiskit.org/documentation/release_notes.html
404 Not Found https://qiskit.org/documentation/retworkx/apiref/retworkx.spring_layout.html function https://qiskit.org/documentation/release_notes.html
404 Not Found https://qiskit.github.io/openqasm/ OpenQASM 3 specification https://qiskit.org/documentation/release_notes.html
404 Not Found https://qiskit.org/documentation/retworkx/stubs/retworkx.vf2_mapping.html retworkx https://qiskit.org/documentation/release_notes.html
404 Not Found https://qiskit.github.io/openqasm/language/openpulse.html OpenPulse https://qiskit.org/documentation/release_notes.html
404 Not Found https://github.com/Qiskit/qiskit-aer/issue/1351 Qiskit/qiskit#1351 https://qiskit.org/documentation/release_notes.html
404 Not Found https://github.com/Qiskit/qiskit-aer/issue/1347 Qiskit/qiskit#1347 https://qiskit.org/documentation/release_notes.html
404 Not Found https://github.com/Qiskit/qiskit-aer/issue/1346 Qiskit/qiskit#1346 https://qiskit.org/documentation/release_notes.html
404 Not Found https://qiskit.org/documentation/_static/thebelab-helper.js script/src https://qiskit.org/documentation/release_notes.html
404 Not Found https://qiskit.org/documentation/_static/js/vendor/popper.min.js script/src https://qiskit.org/documentation/release_notes.html
404 Not Found https://qiskit.org/documentation/_static/js/vendor/bootstrap.min.js script/src https://qiskit.org/documentation/release_notes.html
404 Not Found https://qiskit.org/documentation/_static/js/vendor/anchor.min.js script/src https://qiskit.org/documentation/release_notes.html
404 Not Found https://qiskit.org/documentation/_static/thebelab.css link/href https://qiskit.org/documentation/release_notes.html
404 Not Found https://github.com/Qiskit/qiskit-aqua/blob/main/CHANGELOG.md changelog [302 from https://github.com/Qiskit/qiskit-aqua/blob/master/CHANGELOG.md] https://qiskit.org/documentation/release_notes.html
@1ucian0 1ucian0 added good first issue Good for newcomers documentation Something is not clear or error in description labels May 12, 2023
@shoaib6174
Copy link
Contributor

Hello there,

I would like to work on this issue. Could I be assigned please?

@jakelishman
Copy link
Member

This link checker appears to be inaccurate - several of these actually work. Ones that have retworkx in them need to be updated to rustworkx, and the Aer issues are mostly just because in GH issues links, the correct URL has plural "issues" in the middle (as opposed to PRs, which just have the singular "pull").

The script/src links would be bugs to be filed against the Sphinx theme, if anything. All the rest of these would need to be fixed on the metapackage, since that's where the release_notes.rst file lives.

@joeswashington
Copy link

I could also work on this issue @jakelishman. Not sure if multiple people can be assigned to one issue?

@shoaib6174
Copy link
Contributor

This link checker appears to be inaccurate - several of these actually work. Ones that have retworkx in them need to be updated to rustworkx, and the Aer issues are mostly just because in GH issues links, the correct URL has plural "issues" in the middle (as opposed to PRs, which just have the singular "pull").

The script/src links would be bugs to be filed against the Sphinx theme, if anything. All the rest of these would need to be fixed on the metapackage, since that's where the release_notes.rst file lives.

@jakelishman , I have updated all the links except script/src. I would need some more time to understand the Sphinx theme. Before creating the PR I would like to check the following with you to be sure-

Among the updated links-

I have made the changes in the release_notes.rst of qiskit-metapackage . Is changing the links only in the release_notes.rst of qiskit-metapackage sufficient as some of these broken links are present in the releasenotes of their own repo (such as: https://github.com/search?q=org%3AQiskit%20https%3A%2F%2Fqiskit.github.io%2Fopenqasm%2F&type=code)?

@1ucian0
Copy link
Member Author

1ucian0 commented May 19, 2023

Moving this issue to the meta-package (although, I think it would make sense to fix it them here too at some point, for consistency. But that's another issue).

Hi @shoaib6174, assigning you! Please PR your changes so we can talk on a case-by-case.

@1ucian0 1ucian0 transferred this issue from Qiskit/qiskit May 19, 2023
@Eric-Arellano
Copy link
Collaborator

A lot of these should be fixed by #1737.

@mergify mergify bot closed this as completed in #1741 May 21, 2023
mergify bot pushed a commit that referenced this issue May 21, 2023
* fixed broken links #1739

* Update link for qiski-aqua changelog
jakelishman pushed a commit to jakelishman/qiskit-terra that referenced this issue Aug 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Something is not clear or error in description good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants