Skip to content
This repository has been archived by the owner on Jul 28, 2023. It is now read-only.

Add paging support for experiments and analysis results #807

Merged
merged 7 commits into from
Nov 12, 2020

Conversation

jyu00
Copy link
Collaborator

@jyu00 jyu00 commented Nov 2, 2020

Summary

Closes #806 .

Details and comments

@jyu00 jyu00 added backport potential The bug might be minimal and/or import enough to be port to stable Changelog: New Feature Include in the Added section of the changelog labels Nov 2, 2020
Copy link
Contributor

@mriedem mriedem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems there is some missing testing for when limit is explicitly set to None and not the default of 10.

qiskit/providers/ibmq/experiment/experimentservice.py Outdated Show resolved Hide resolved
qiskit/providers/ibmq/experiment/experimentservice.py Outdated Show resolved Hide resolved
@jyu00 jyu00 merged commit fc60113 into Qiskit:master Nov 12, 2020
@jyu00 jyu00 deleted the experiment-pagination branch November 12, 2020 16:21
jyu00 added a commit to jyu00/qiskit-ibmq-provider that referenced this pull request Nov 12, 2020
* add limit

* mypy version

* fix no limit

* delete duplicate release note

* fix limit in test

(cherry picked from commit fc60113)
jyu00 added a commit that referenced this pull request Nov 12, 2020
* add limit

* mypy version

* fix no limit

* delete duplicate release note

* fix limit in test

(cherry picked from commit fc60113)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport potential The bug might be minimal and/or import enough to be port to stable Changelog: New Feature Include in the Added section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(resultsdb) add paging support for experiments and analysis results
2 participants