Skip to content
This repository has been archived by the owner on Jul 28, 2023. It is now read-only.

Add tests different providers #618

Merged
merged 16 commits into from
Apr 15, 2020

Conversation

lgarc15
Copy link
Contributor

@lgarc15 lgarc15 commented Apr 6, 2020

Summary

Addresses #584

Details and comments

test/ibmq/test_basic_server_paths.py Outdated Show resolved Hide resolved
test/ibmq/test_basic_server_paths.py Outdated Show resolved Hide resolved
jyu00
jyu00 previously requested changes Apr 8, 2020
test/ibmq/test_basic_server_paths.py Show resolved Hide resolved
test/ibmq/test_basic_server_paths.py Outdated Show resolved Hide resolved
test/ibmq/test_basic_server_paths.py Outdated Show resolved Hide resolved
test/ibmq/test_basic_server_paths.py Outdated Show resolved Hide resolved
test/ibmq/test_basic_server_paths.py Outdated Show resolved Hide resolved
@lgarc15 lgarc15 force-pushed the add-tests-different-providers branch from 764ab6c to db97de9 Compare April 9, 2020 16:06
@lgarc15 lgarc15 force-pushed the add-tests-different-providers branch from db97de9 to f9baf81 Compare April 9, 2020 16:10
jyu00
jyu00 previously requested changes Apr 13, 2020
test/ibmq/test_basic_server_paths.py Outdated Show resolved Hide resolved
test/ibmq/test_basic_server_paths.py Outdated Show resolved Hide resolved
test/ibmq/test_basic_server_paths.py Outdated Show resolved Hide resolved
@lgarc15 lgarc15 dismissed jyu00’s stale review April 13, 2020 15:15

Addressed review comments

Copy link
Collaborator

@jyu00 jyu00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit but otherwise looks good!

test/ibmq/test_basic_server_paths.py Outdated Show resolved Hide resolved
@jyu00 jyu00 merged commit 22e9b8d into Qiskit:master Apr 15, 2020
@jyu00 jyu00 mentioned this pull request Apr 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants