This repository has been archived by the owner on Jul 28, 2023. It is now read-only.
Allow saving default provider in account #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
March 25, 2020 15:46
lgarc15
commented
Mar 27, 2020
jyu00
previously requested changes
Mar 27, 2020
Still need to update the tutorial, but it should be good for review. |
added 8 commits
March 31, 2020 14:34
jyu00
reviewed
Apr 1, 2020
added 7 commits
April 2, 2020 09:45
jyu00
previously requested changes
Apr 6, 2020
qiskit/providers/ibmq/ibmqfactory.py
Outdated
| @@ -38,7 +40,25 @@ | |||
|
|
|||
|
|
|||
| class IBMQFactory: | |||
| """Factory and account manager for IBM Quantum Experience.""" | |||
| """Factory and account manager for IBM Quantum Experience. | |||
|
|
|||
There was a problem hiding this comment.
What I meant was that since this block comment is meant to describe the the entire IBMQFactory class, it should contain more information than just how to save a default provider. Like it should explain what this class is used for and the terminologies (token, provider, configuration file, etc). Perhaps this can go into a different doc PR.
Note that my original comment regarding the docstring was
Perhaps a nice, concise description, of how to use IBMQFactory to manage accounts can go into IBMQFactory's docstring.
Also while it doesn't hurt to give users more information, I don't think it's necessary to describe in details how to specify a default provider.
|
Also, as a note. Per your suggestion, I'll create another PR to handle the documentation for |
jyu00
reviewed
Apr 8, 2020
jyu00
approved these changes
Apr 9, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #545
Details and comments
Allows saving a default provider with
save_account()and enabling a default provider usingenable_account()by specifying a provider as a string in the format<hub_name>/<group_name>/<project_name>.