Skip to content
This repository has been archived by the owner on Jul 28, 2023. It is now read-only.

Add deprecation warning #1140

Merged
merged 22 commits into from
Jan 31, 2023
Merged

Add deprecation warning #1140

merged 22 commits into from
Jan 31, 2023

Conversation

kt474
Copy link
Member

@kt474 kt474 commented Aug 8, 2022

Summary

fixes #1042

Details and comments

@kt474
Copy link
Member Author

kt474 commented Aug 8, 2022

@rathishcholarajan can you take a look

@kt474
Copy link
Member Author

kt474 commented Aug 9, 2022

@renier

@mtreinish
Copy link
Member

So I'm a bit confused here, what is the status of qiskit-ibm-provider if we're telling people to use the runtime client instead? They're not equivalent sets of functionality. I get you're adding an interface for doing backend.run() via the circuit runner, but is that all that's needed? What about the other IQX api functionality? Also what about the in progress PRs like: Qiskit/qiskit-ibm-provider#365 ?

@kt474
Copy link
Member Author

kt474 commented Aug 10, 2022

So I'm a bit confused here, what is the status of qiskit-ibm-provider if we're telling people to use the runtime client instead? They're not equivalent sets of functionality. I get you're adding an interface for doing backend.run() via the circuit runner, but is that all that's needed? What about the other IQX api functionality? Also what about the in progress PRs like: Qiskit/qiskit-ibm-provider#365 ?

@renier - also unsure about the exact plan for this repo qiskit-ibm-provider

@1ucian0
Copy link
Member

1ucian0 commented Aug 10, 2022

I get you're adding an interface for doing backend.run() via the circuit runner, but is that all that's needed?

For reference Qiskit/qiskit-ibm-runtime#459

@kt474 kt474 added the on hold Can not fix yet label Aug 15, 2022
@kt474 kt474 removed the on hold Can not fix yet label Sep 7, 2022
@jyu00 jyu00 added the on hold Can not fix yet label Sep 21, 2022
@jyu00
Copy link
Collaborator

jyu00 commented Sep 21, 2022

Putting on hold label back on. Like Matthew said we shouldn't deprecate this until there is a replacement.

"for the next 3 months and then this package will no longer be supported. Please begin to use "
"qiskit-ibm-provider (https://github.com/Qiskit/qiskit-ibm-provider) and "
"qiskit-ibm-runtime (https://github.com/Qiskit/qiskit-ibm-runtime) instead.",
DeprecationWarning,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FutureWarning?

warnings.warn(
f"The package {__name__} is being deprecated. "
"Please see "
"https://qiskit.org/documentation/partners/qiskit_ibm_provider/tutorials/Migration_Guide_from_qiskit-ibmq-provider.html"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just created ibm.biz/provider_migration_guide, which is shorter and can be updated if the url changes. Maybe a better option?

Suggested change
"https://qiskit.org/documentation/partners/qiskit_ibm_provider/tutorials/Migration_Guide_from_qiskit-ibmq-provider.html"
"https://ibm.biz/provider_migration_guide"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just FYI the original link was added to the release note of Qiskit/qiskit#8080. If the url changes, we can consider change there as well.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But probably the best way to handle the link change would be redirect the original link to the new link. This can be done in sphinx using reredirect extension. Anyway, we don't need to worry about that now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate qiskit-ibmq-provider
5 participants