This repository has been archived by the owner on Jul 28, 2023. It is now read-only.
Remove marshmallow #553
Assignees
Labels
Comments
|
I started this in: #555 |
mtreinish
added a commit
to mtreinish/qiskit-ibmq-provider
that referenced
this issue
Feb 19, 2020
The qobj payload has a couple of quirks related to how qobj objects can be constructed (and will be constructed after Qiskit/qiskit#3383 merges) that aren't handled by the default json encoder. The first is that complex numbers are converted to the form "(real, imaginary)", and the second is that numpy arrays are sometimes part of the payload. Instead of relying on a layer outside of the provider coercing these objects to the expected format this commit changes how we push qobj payloads to the iqx api so that we run it through a json encoder that understands how to do this. After this commit qiskit-ibmq-provider owns it's own payload format and the generation of the expected json payload format instead of relying on an external library to handle it for us. Related to Qiskit#553
mtreinish
added a commit
to mtreinish/qiskit-ibmq-provider
that referenced
this issue
Feb 19, 2020
The qobj payload has a couple of quirks related to how qobj objects can be constructed (and will be constructed after Qiskit/qiskit#3383 merges) that aren't handled by the default json encoder. The first is that complex numbers are converted to the form "(real, imaginary)", and the second is that numpy arrays are sometimes part of the payload. Instead of relying on a layer outside of the provider coercing these objects to the expected format this commit changes how we push qobj payloads to the iqx api so that we run it through a json encoder that understands how to do this. After this commit qiskit-ibmq-provider owns it's own payload format and the generation of the expected json payload format instead of relying on an external library to handle it for us. Related to Qiskit#553
mtreinish
added a commit
to mtreinish/qiskit-ibmq-provider
that referenced
this issue
Feb 19, 2020
The qobj payload has a couple of quirks related to how qobj objects can be constructed (and will be constructed after Qiskit/qiskit#3383 merges) that aren't handled by the default json encoder. The first is that complex numbers are converted to the form "(real, imaginary)", and the second is that numpy arrays are sometimes part of the payload. Instead of relying on a layer outside of the provider coercing these objects to the expected format this commit changes how we push qobj payloads to the iqx api so that we run it through a json encoder that understands how to do this. After this commit qiskit-ibmq-provider owns it's own payload format and the generation of the expected json payload format instead of relying on an external library to handle it for us. Related to Qiskit#553
jyu00
added a commit
that referenced
this issue
Feb 21, 2020
The qobj payload has a couple of quirks related to how qobj objects can be constructed (and will be constructed after Qiskit/qiskit#3383 merges) that aren't handled by the default json encoder. The first is that complex numbers are converted to the form "(real, imaginary)", and the second is that numpy arrays are sometimes part of the payload. Instead of relying on a layer outside of the provider coercing these objects to the expected format this commit changes how we push qobj payloads to the iqx api so that we run it through a json encoder that understands how to do this. After this commit qiskit-ibmq-provider owns it's own payload format and the generation of the expected json payload format instead of relying on an external library to handle it for us. Related to #553 Co-authored-by: Jessie Yu <[email protected]>
|
One thing to note is that for complex numbers, marshmallow used to convert them from list to complex when a |
This was referenced Apr 17, 2020
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
What is the expected behavior?
qiskit-terrais moving away from marshmallow due to performance. The provider will need to stop using terra's marshmallow schemas as well as removing its own, since it relies on terra's methods and for consistency.This needs to be in sync with Qiskit/qiskit#3383 which removes schemas like
QobjSchemaused by the provider.Tasks:
The text was updated successfully, but these errors were encountered: