Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use service defined by user as default #955

Merged
merged 16 commits into from
Aug 16, 2023
Merged

Use service defined by user as default #955

merged 16 commits into from
Aug 16, 2023

Conversation

merav-aharoni
Copy link
Contributor

@merav-aharoni merav-aharoni commented Jul 16, 2023 •
edited
Loading

Summary

If the user defines a QiskitRuntimeService, then that service will be treated as the default service in the program.

Details and comments

This is implemented by adding a static member QiskitRuntimeService.global_service. The primitive will use that last defined service as its service.

Fixes #923.

@coveralls
Copy link

coveralls commented Jul 27, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5883489656

  • 9 of 9 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 74.058%
Totals Coverage Status
Change from base Build 5881922087: 0.04%
Covered Lines: 2458
Relevant Lines: 3319
💛 - Coveralls

@merav-aharoni merav-aharoni marked this pull request as ready for review July 27, 2023 11:40
@merav-aharoni merav-aharoni requested a review from kt474 July 27, 2023 11:40
kt474
kt474 approved these changes Aug 16, 2023
View reviewed changes
Copy link
Member

@kt474 kt474 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt474 kt474 mentioned this pull request Aug 16, 2023
Closed
@kt474 kt474 merged commit ab01504 into Qiskit:main Aug 16, 2023
@merav-aharoni merav-aharoni deleted the global_service branch August 17, 2023 13:27
@kt474 kt474 added this to the 0.12.0 milestone Aug 18, 2023
@jyu00 jyu00 mentioned this pull request Jul 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt474 kt474 kt474 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.

Use service already initialized
3 participants
@merav-aharoni @coveralls @kt474