Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate interim results #1776

Merged
merged 4 commits into from
Jul 1, 2024
Merged

Deprecate interim results #1776

merged 4 commits into from
Jul 1, 2024

Conversation

kt474
Copy link
Member

@kt474 kt474 commented Jun 27, 2024 •
edited
Loading

Summary

We'll need a follow up PR after the deprecation period to remove all of the interim results streaming code.

Details and comments

Fixes #1774

@kt474 kt474 added the Changelog: Deprecation Include in Deprecated section of changelog label Jun 27, 2024
@coveralls
Copy link

coveralls commented Jun 27, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9700536342

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 82.129%
Totals Coverage Status
Change from base Build 9689666268: 0.04%
Covered Lines: 6117
Relevant Lines: 7448
💛 - Coveralls

@kt474 kt474 mentioned this pull request Jun 27, 2024
Merged
@coveralls
Copy link

coveralls commented Jun 28, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9715892712

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 82.123%
Totals Coverage Status
Change from base Build 9715853171: 0.04%
Covered Lines: 6119
Relevant Lines: 7451
💛 - Coveralls

@kt474 kt474 merged commit b6865b4 into Qiskit:main Jul 1, 2024
18 checks passed
@kt474 kt474 deleted the deprecate-interim-results branch July 1, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptristan3 ptristan3 ptristan3 approved these changes

Assignees
No one assigned
Labels
Changelog: Deprecation Include in Deprecated section of changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate interim result streaming
3 participants
@kt474 @coveralls @ptristan3