Add RuntimeJobV2 class and new JobStatus' #1450
Conversation
Pull Request Test Coverage Report for Build 8162277899Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
kt474
changed the title
kt474
changed the title
kt474
changed the title
qiskit_ibm_runtime/runtime_job_v2.py
Outdated
| def _set_status_and_error_message(self) -> None: | ||
| """Fetch and set status and error message.""" | ||
| if self._status not in JOB_FINAL_STATES: |
There was a problem hiding this comment.
I don't think these methods need to be duplicated, especially since there are methods like in_final_state()
There was a problem hiding this comment.
If these status related methods are in BaseRuntimeJob instead, it makes things messier because JOB_FINAL_STATES is different, and all the statuses are strings instead of enums.
There was a problem hiding this comment.
But if the only difference is JOB_FINAL_STATES, and you're just checking if a status is in final state, can't you just call if not self.in_final_state() and have each child implement its own in_final_state() ?
| @abstractmethod | ||
| def _status_from_job_response(self, response: Dict) -> str: | ||
| """Returns the job status from an API response.""" | ||
| return response["state"]["status"].upper() |
There was a problem hiding this comment.
Wasn't sure what the best way to handle this _status_from_job_response method was - I don't think it's best practice to make a private method abstract but it makes sense for the child classes to have to implement this method since the API_TO_JOB_STATUS is different
kt474
added
the
Changelog: New Feature
Summary
Details and comments
Fixes #1352
Fixes #1366