Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated CHSH to use four steps + Batch #1215

Merged
merged 10 commits into from
Nov 13, 2023
Merged

Updated CHSH to use four steps + Batch #1215

merged 10 commits into from
Nov 13, 2023

Conversation

pandasa123
Copy link
Contributor

@pandasa123 pandasa123 commented Nov 13, 2023 •
edited
Loading

Summary

These updates focus on making tutorials more consistent, including:

  • 4 step format
  • New Batch context manager
  • Removing online simulator, and adding a note to run with local qiskit.primitives simulator
  • Updated theme
  • Removed version table

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@pandasa123 pandasa123 changed the title Updated CHSH to use four steps Updated CHSH to use four steps + Batch Nov 13, 2023
@kt474 kt474 requested a review from beckykd November 13, 2023 17:20
beckykd
beckykd approved these changes Nov 13, 2023
View reviewed changes
docs/tutorials/chsh_with_estimator.ipynb Outdated Show resolved Hide resolved
docs/tutorials/chsh_with_estimator.ipynb Outdated Show resolved Hide resolved
docs/tutorials/chsh_with_estimator.ipynb Outdated Show resolved Hide resolved
docs/tutorials/chsh_with_estimator.ipynb Outdated Show resolved Hide resolved
docs/tutorials/chsh_with_estimator.ipynb Outdated Show resolved Hide resolved
docs/tutorials/chsh_with_estimator.ipynb Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Nov 13, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6855294386

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on chsh_tutorial_update_nov at 55.872%
Totals Coverage Status
Change from base Build 6855285488: 55.9%
Covered Lines: 2469
Relevant Lines: 4419
💛 - Coveralls

@kt474 kt474 merged commit 39d56ff into Qiskit:main Nov 13, 2023
14 checks passed
@kt474 kt474 added this to the 0.15.0 milestone Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beckykd beckykd beckykd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.
4 participants
@pandasa123 @coveralls @beckykd @kt474