Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated VQE tutorial #1207

Merged
merged 26 commits into from
Nov 13, 2023
Merged

Updated VQE tutorial #1207

merged 26 commits into from
Nov 13, 2023

Conversation

pandasa123
Copy link
Contributor

@pandasa123 pandasa123 commented Nov 8, 2023

This uses the new Runtime transpilation passes for 0.14.1!

Summary

These updates focus on making tutorials more consistent, including:

  • 4 step format
  • Removing online simulator, and adding a note to run with local qiskit.primitives simulator
  • Updated theme
  • Removed version table

Additionally, this tutorial content has been modified to show:

  • One workflow with a callback, rather than two separate runs
  • Local transpilation with qiskit's PassManager and Runtime's new transpilation passes ALAPScheduleAnalysis and PadDynamicalDecoupling

…one run only, updated theme, and replaced version table
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@coveralls
Copy link

coveralls commented Nov 9, 2023

Pull Request Test Coverage Report for Build 6855203863

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.872%

Totals Coverage Status
Change from base Build 6853319603: 0.0%
Covered Lines: 2469
Relevant Lines: 4419

💛 - Coveralls

@jyu00
Copy link
Collaborator

jyu00 commented Nov 9, 2023

A couple of comments:

  1. It'd be nice to explain why we want to use those passes
  2. Since you are transpiling locally, you want to specify skip_transpilation=False, otherwise the primitives will do it again.

@kt474 kt474 requested a review from beckykd November 13, 2023 17:21
docs/tutorials/vqe_with_estimator.ipynb Outdated Show resolved Hide resolved
docs/tutorials/vqe_with_estimator.ipynb Outdated Show resolved Hide resolved
docs/tutorials/vqe_with_estimator.ipynb Outdated Show resolved Hide resolved
docs/tutorials/vqe_with_estimator.ipynb Outdated Show resolved Hide resolved
docs/tutorials/vqe_with_estimator.ipynb Outdated Show resolved Hide resolved
docs/tutorials/vqe_with_estimator.ipynb Outdated Show resolved Hide resolved
docs/tutorials/vqe_with_estimator.ipynb Outdated Show resolved Hide resolved
docs/tutorials/vqe_with_estimator.ipynb Outdated Show resolved Hide resolved
@kt474 kt474 merged commit 7700611 into Qiskit:main Nov 13, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants