Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning if DE env is used #1201

Merged
merged 3 commits into from
Nov 8, 2023
Merged

Add warning if DE env is used #1201

merged 3 commits into from
Nov 8, 2023

Conversation

kt474
Copy link
Member

@kt474 kt474 commented Nov 7, 2023

Summary

Details and comments

Fixes #

@kt474 kt474 requested a review from merav-aharoni November 7, 2023 23:07
@kt474 kt474 added this to the 0.14.1 milestone Nov 7, 2023
@coveralls
Copy link

coveralls commented Nov 7, 2023

Pull Request Test Coverage Report for Build 6803065594

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 1 of 2 (50.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on de-warning at 55.972%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit_ibm_runtime/qiskit_runtime_service.py 1 2 50.0%
Totals Coverage Status
Change from base Build 6802993984: 56.0%
Covered Lines: 2465
Relevant Lines: 4404

💛 - Coveralls

@kt474 kt474 requested a review from drew-distefano November 7, 2023 23:17
Copy link
Contributor

@merav-aharoni merav-aharoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt474 kt474 merged commit e6e7a3b into Qiskit:main Nov 8, 2023
14 checks passed
@kt474 kt474 deleted the de-warning branch November 8, 2023 19:32
@@ -210,6 +210,11 @@ def __init__(
auth_client = self._authenticate_ibm_quantum_account(self._client_params)
# Update client parameters to use authenticated values.
self._client_params.url = auth_client.current_service_urls()["services"]["runtime"]
if self._client_params.url == "https://api.de.quantum-computing.ibm.com/runtime":
warnings.warn(
"Features in versions of qiskit-ibm-runtime greater than 0.13.0 may not "
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Late, but doesn't this technically include 0.13.0? (.e. 0.13.0 and above?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'll update the wording in another PR
greater than and including 0.13.0...

@kt474 kt474 modified the milestones: 0.14.1, 0.15.0 Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants