Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add channel strategy instance validation #1193

Merged
merged 5 commits into from
Nov 9, 2023
Merged

Add channel strategy instance validation #1193

merged 5 commits into from
Nov 9, 2023

Conversation

kt474
Copy link
Member

@kt474 kt474 commented Nov 3, 2023

Summary

If q-ctrl is passed in as the channel_strategy but the instance does not have it enabled, the following error will be raised:

IBMNotAuthorizedError: 'This account is not authorized to use ``q-ctrl`` as a channel strategy.'

Details and comments

Fixes #1176

@coveralls
Copy link

coveralls commented Nov 6, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6814202745

  • 5 of 11 (45.45%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 55.926%
Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit_ibm_runtime/api/clients/runtime.py 1 2 50.0%
qiskit_ibm_runtime/api/rest/runtime.py 1 3 33.33%
qiskit_ibm_runtime/qiskit_runtime_service.py 3 6 50.0%
Totals Coverage Status
Change from base Build 6805378383: -0.03%
Covered Lines: 2468
Relevant Lines: 4413
💛 - Coveralls

@kt474 kt474 added the Changelog: New Feature Include in the Added section of the changelog label Nov 6, 2023
merav-aharoni
merav-aharoni approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@merav-aharoni merav-aharoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo and missing endline in release note. Otherwise fine.

releasenotes/notes/channel-strategy-instance-validate-639b18b8c5d44678.yaml Outdated Show resolved Hide resolved
@kt474 kt474 merged commit 1196556 into Qiskit:main Nov 9, 2023
17 checks passed
@kt474 kt474 deleted the check-qtrl-instance branch November 9, 2023 17:22
@kt474 kt474 mentioned this pull request Nov 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merav-aharoni merav-aharoni merav-aharoni approved these changes

@rathishcholarajan rathishcholarajan Awaiting requested review from rathishcholarajan

Assignees
No one assigned
Labels
Changelog: New Feature Include in the Added section of the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check instance at initialization for Q-CTRL validation
3 participants
@kt474 @coveralls @merav-aharoni