-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support IBMBackend.run() #1138
Support IBMBackend.run() #1138
Conversation
Pull Request Test Coverage Report for Build 6790823703Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
…time into backend_run
…ory to support convert_id_to_delay
…time into backend_run
@jyu00 , @kt474 - I would appreciate your inputs on the tests for this PR before I continue. My approach has been the following:
|
A few open issues:
No.
Are you referring to job status? Don't they come from Qiskit?
Replacing with something already here seems easier?
No. Qiskit Runtime API doesn't support filtering by granular statuses, so we had to do some complicated stuff in qiskit-ibm-provider for backward compatibility. Since no one has complained about not having this support in qiskit-ibm-runtime, let's just leave out the complexity.
I guess we can keep
Yeah, I think people will be more interested in
Let's not do this right now, since it'll change with granular job status.
I don't understand your comment about the
Yes. They are good to ensure if something goes horribly wrong by verifying the results. It'd be good to have similar tests for real backends as well, but result verification could be difficult.
How about |
Co-authored-by: Jessie Yu <[email protected]>
@jyu00 - I addressed all your comments from yesterday. Please have a look. |
…time into backend_run
…time into backend_run
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small comment but otherwise LGTM
Thanks @merav-aharoni! 🎉 |
Summary
The
backend.run()
functionality was copied fromqiskit-ibm-provider
. I made adjustment as needed. Also copied all the tests that I thought were relevant.A few open issues:
qiskit-ibm-runtime.Options
forIBMBackend
?Session
fromprovider
withSession
here. Currently have 2 separate classes - TBD in Enable Session to contain both primitive.run and backend.run #1180.test-ibm-job.py
withtest-job.py
? or keep it separate and change the name? - for now keeping both.status
values fromqiskit-ibm-provider
?qiskit-ibm-provider
with those here - do when the provider is merged into runtime.test_ibm_job.py
redundant wrt existing tests here? - for now keeping all tests here.test/fake_account_client.py
do we need the methods here or should they be replaced by something already here? - issue Check if there is duplication between test/fake_account_client.py and other test method #1160statuses
inQiskit.RuntimeService.jobs()
as inprovider.backend.jobs()
? See for exampletest_retrieve_jobs_with_status
in the provider. - No, see @jyu00 's comment below.RuntimeJob.test_refresh_job_result
,test_job_tags_replace
skipped - how do we supportrefresh
in runtime? - issue Supportrefresh
functionality #1159.RuntimeJob.test_queue_info
- Do we want to supportqueue_info
in runtime? - issue support queue_info #1161.RuntimeJob.time_per_step
- do we want to support it? - on hold for now.transpiler/passmanger
directory was copied over to support_deprecate_id_instruction
, which is already deprecated. Can we remove? - removed_deprecate_id_instruction
.Details and comments
Fixes #1117