This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
Update uses of FakeBackends to be compatible with 0.45 and 1.0
#808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElePT
commented
Feb 5, 2024
ElePT
commented
Feb 5, 2024
Comment on lines
+35
to
+41
| .. jupyter-execute:: | ||
| :hide-code: | ||
| :hide-output: | ||
|
|
||
| import warnings | ||
| warnings.filterwarnings("ignore", category=DeprecationWarning) | ||
|
|
There was a problem hiding this comment.
The only way I found to make the docs build pass was to filter the deprecation warning raised in 0.45 after the try-except. It's not ideal to have the try-except in an example, but these examples are run. An alternative would be to skip the run, in that case we wouldn't need the try-except or the filter.
Pull Request Test Coverage Report for Build 7787190529
💛 - Coveralls |
kt474
approved these changes
Feb 5, 2024
|
LGTM, I can handle the merge conflicts in #804 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I just naively modified all the fake backends I found in the code, but I see that #804 removes some of these files, I can prune the changes in this PR to match #804 if necessary.
Related to #804.