This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
Fix ConvertIdToDelay with conditional IGates
#688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logic of `DAGCircuit.substitute_node` already contains logic that propagates the condition from one node to another. The provider was previously duplicating this and before Terra 0.25, Qiskit would silently buggily overwrite any condition in the substitution. Now Qiskit will refuse, but the behaviour of propagating a set condition persists.
Pull Request Test Coverage Report for Build 5715631452
💛 - Coveralls |
kt474
approved these changes
Jul 31, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The logic of
DAGCircuit.substitute_nodealready contains logic that propagates the condition from one node to another. The provider was previously duplicating this and before Terra 0.25, Qiskit would silently buggily overwrite any condition in the substitution. Now Qiskit will refuse, but the behaviour of propagating a set condition persists.Details and comments
Work in Qiskit/qiskit#10314 may switch from directly setting
.conditionto usingInstruction.c_if, which could pose problems for Terra's inbuiltDelay, which claims not to support conditional operations. We can look at relaxing that, if it's something you guys need - I'm not sure it's Terra's domain to be saying that.