Fix JSONDecoder 'encoding' bug

[kt474]

Summary

This has been reported 3 times now - #528, #647, and on slack. I have been unable to replicate this issue but this was a suggested fix.

JSONDecoder.__init__() got an unexpected keyword argument 'encoding'

The keyword argument encoding was removed in python 3.9 https://docs.python.org/3/library/json.html#json.loads but I'm not sure if that's related to this error (2 of the users were using python 3.10, 1 was using python 3.8).

thoughts @jyu00 @merav-aharoni?

Update: figured it out, explained in comment below

Details and comments

[merav-aharoni]

I don't really have anything helpful to say. I ran the two cases using python 3.10 and did not get the error.
Perhaps add a print a better error message or warning, in case encoding appears, to print the full response from self.session.get(self.get_url("self")).json()) to help debug next time this happens.

[kt474]

After lots of digging, I found that we are having the same issue reported in psf/requests#4842.

It appears that when simplejson is in the environment requests preferentially imports it. However, the arguments accepted by JSONDecoder are inconsistent between the standard library json and simplejson leading to errors when using the standard json.JSONDecoder when simplejson is in the environment.

Since simplejson is not part of this repo the easy solution would be to inform the users to uninstall this package but since this issue has come up a lot recently, we could add some warning/check.

[coveralls]

Pull Request Test Coverage Report for Build 5147280181

• 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.008%) to 51.854%

---

Totals
Change from base Build 5147270039:	0.008%
Covered Lines:	3133
Relevant Lines:	6042

---

💛 - Coveralls