Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Change circuit attribute check order #639

Merged
merged 3 commits into from
May 25, 2023
Merged

Change circuit attribute check order #639

merged 3 commits into from
May 25, 2023

Conversation

kt474
Copy link
Member

@kt474 kt474 commented May 23, 2023

Summary

Missed this earlier - we have to check for Schedule first because if a schedule is passed in, it would result in an error.

AttributeError: 'Schedule' object has no attribute 'num_qubits'

https://github.com/Qiskit/qiskit-ibm-provider/actions/runs/5049261020/jobs/9058655851#step:5:855

Details and comments

@kt474 kt474 added the Changelog: Bugfix Include in the Fixed section of the changelog label May 23, 2023
@kt474 kt474 requested a review from merav-aharoni May 23, 2023 20:03
@coveralls
Copy link

coveralls commented May 23, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5082586738

  • 1 of 2 (50.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 50.215%
Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit_ibm_provider/ibm_backend.py 1 2 50.0%
Totals Coverage Status
Change from base Build 5082584956: 0%
Covered Lines: 3032
Relevant Lines: 6038
💛 - Coveralls

merav-aharoni
merav-aharoni approved these changes May 25, 2023
View reviewed changes
Copy link
Collaborator

@merav-aharoni merav-aharoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kt474 kt474 merged commit 7b28e69 into Qiskit:main May 25, 2023
@kt474 kt474 deleted the fix-check-order branch May 25, 2023 17:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@merav-aharoni merav-aharoni merav-aharoni approved these changes

Assignees
No one assigned
Labels
Changelog: Bugfix Include in the Fixed section of the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kt474 @coveralls @merav-aharoni