-
Notifications
You must be signed in to change notification settings - Fork 67
Conversation
Pull Request Test Coverage Report for Build 5614902096
💛 - Coveralls |
The file |
Those tests don't seem to be testing the decoding. For example, if I comment out the lines below, those tests still pass. qiskit-ibm-provider/qiskit_ibm_provider/utils/json_decoder.py Lines 111 to 113 in e2e4463
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think your linter/editor reorganized the order of the dependencies, but the change itself LGTM
@nkanazawa1989 this adds on to your PR from #413
I did add an import statement and then used ruff to reorganize the imports. That's an improvement though, right? Do you want me to revert it? |
Summary
Adds
switch_case
to the JSON decoder. Not sure if/how this should be tested. Please advise.Details and comments