This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Scheduling and Dynamical Decoupling to support block-based control flow #480
Update Scheduling and Dynamical Decoupling to support block-based control flow #480
Changes from all commits
599fad9
130b838
5b2a762
95652aa
b2b5a90
85990fb
8575255
e9fe2bc
bda0d66
8f2307e
e9b32ec
d8540c2
07dc71e
98d57c6
7cd75fd
4bec4bd
b264e5a
cc759d0
efc2c1f
cb81164
4a0b424
ca8a6ac
9ad65f1
ef10366
1d553c2
c820ac3
588d316
c7ec172
a173817
396795b
e9efd32
bcc1c9a
f81e338
3d69f69
73679b1
27ff3c0
49ceb6f
cea166a
9b1107d
4d2479c
e7f1086
6a69587
c857bd9
155db53
3362c69
e85a0a1
c960ac9
8bfec24
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Unrelated to review, it's just me asking to get better intuition.) If I logically wanted to do
if (c) {x $0; x $1;}
, is it likely thatif (c) x $0; if (c) x $1;
would have significantly different error performance on our hardware because of the fast-path, assuming I'm going to use both$0
and$1
later. My gut says that putting both into a slow-path block would be better, because then neither is idle waiting for the other.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It depends on the measurement result. If
c
is directly a result from predcessor measurements thenif (c) x $0; if (c) x $1;
will take the same amount of time asif (c) x $0;
(as it will be done in parallel) as you said with the fast-path so neither is waiting.